Skip to content

test(e2e): wait for durable child failure status - #4213

Merged
igor-kupczynski merged 1 commit into
mainfrom
cursor/stabilize-durable-child-status-daec
Jun 17, 2026
Merged

test(e2e): wait for durable child failure status#4213
igor-kupczynski merged 1 commit into
mainfrom
cursor/stabilize-durable-child-status-daec

Conversation

@igor-kupczynski

@igor-kupczynski igor-kupczynski commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

Stabilizes TestDurableErrorOnErrorInChild by waiting for the child run status to become FAILED instead of asserting a single immediate GetStatus read.

The durable parent already observes the child failure and returns the expected child error details. The failing CI logs showed the immediate child status read racing status materialization, returning RUNNING or QUEUED before eventually becoming terminal.

Fixes # (issue)

Type of change

  • Test changes (add, refactor, improve or change a test)

What's Changed

  • Reuse the existing e2e pollUntil helper for the child failure status assertion in TestDurableErrorOnErrorInChild
  • Keep the durable parent output assertions and parent completion polling unchanged

Checklist

Changes have been:

  • Tested (unit, integration, or manually with steps specified)
  • Linted and formatted
  • Documented (where applicable)
  • Added to CHANGELOG (where applicable) -- see Keep a Changelog

Testing

  • gofmt -w sdks/go/e2e/durable_test.go
  • Attempted: go test -c -tags e2e -o /tmp/hatchet-e2e.test ./sdks/go/e2e
    • Blocked in this environment because the repo requires Go 1.26 and the local toolchain is Go 1.22.2; automatic Go 1.26 toolchain download returned toolchain not available.

AI Disclosure
  • I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.

  • Details: Investigation, test update, and PR description authored with Cursor.

Co-authored-by: Igor Kupczyński <igor-kupczynski@users.noreply.github.com>
@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hatchet-docs Ready Ready Preview, Comment Jun 16, 2026 12:21pm

Request Review

@github-actions github-actions Bot added the sdk-go Related to the Go SDK label Jun 16, 2026
@igor-kupczynski
igor-kupczynski marked this pull request as ready for review June 17, 2026 08:16
@igor-kupczynski igor-kupczynski added the ci-health CI/test reliability work tracked by the CI Health Dashboard label Jun 17, 2026
@igor-kupczynski
igor-kupczynski requested a review from mnafees June 17, 2026 08:17
@igor-kupczynski
igor-kupczynski merged commit 5c8ae20 into main Jun 17, 2026
33 of 39 checks passed
@igor-kupczynski
igor-kupczynski deleted the cursor/stabilize-durable-child-status-daec branch June 17, 2026 11:41
@github-actions github-actions Bot mentioned this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-health CI/test reliability work tracked by the CI Health Dashboard sdk-go Related to the Go SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants