test(e2e): wait for durable child failure status - #4213
Merged
Conversation
Co-authored-by: Igor Kupczyński <igor-kupczynski@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
igor-kupczynski
marked this pull request as ready for review
June 17, 2026 08:16
mnafees
approved these changes
Jun 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilizes
TestDurableErrorOnErrorInChildby waiting for the child run status to becomeFAILEDinstead of asserting a single immediateGetStatusread.The durable parent already observes the child failure and returns the expected child error details. The failing CI logs showed the immediate child status read racing status materialization, returning
RUNNINGorQUEUEDbefore eventually becoming terminal.Fixes # (issue)
Type of change
What's Changed
pollUntilhelper for the child failure status assertion inTestDurableErrorOnErrorInChildChecklist
Changes have been:
Testing
gofmt -w sdks/go/e2e/durable_test.gogo test -c -tags e2e -o /tmp/hatchet-e2e.test ./sdks/go/e2etoolchain not available.AI Disclosure
I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
Details: Investigation, test update, and PR description authored with Cursor.