test(e2e): wait for durable terminal statuses - #4239
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
igor-kupczynski
marked this pull request as ready for review
June 19, 2026 12:33
mnafees
approved these changes
Jun 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilizes the TypeScript durable e2e test that checks a parent task catching a failed child run. The test now waits for the child run to reach
FAILEDand the parent run to reachCOMPLETEDinstead of stopping on any non-null status such asQUEUEDorRUNNING.Refs #4204
Type of change
What's Changed
FAILEDbefore asserting.COMPLETEDbefore asserting.Checklist
Changes have been:
Testing
pnpm exec prettier src/v1/examples/durable/durable.e2e.ts --checkpnpm exec eslint src/v1/examples/durable/durable.e2e.tspnpm exec tsc --noEmitpnpm test:e2e, per local DB safety constraints. CI should cover the TypeScripttest-e2eandold-engine-new-sdkjobs.🤖 AI Disclosure
I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
Details: Used Cursor agent and a Composer subagent to update the durable e2e polling predicates and run static TypeScript checks.