Skip to content

test(e2e): wait for durable terminal statuses - #4239

Merged
igor-kupczynski merged 1 commit into
mainfrom
stabilize-typescript-durable-polling
Jun 19, 2026
Merged

test(e2e): wait for durable terminal statuses#4239
igor-kupczynski merged 1 commit into
mainfrom
stabilize-typescript-durable-polling

Conversation

@igor-kupczynski

@igor-kupczynski igor-kupczynski commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

Stabilizes the TypeScript durable e2e test that checks a parent task catching a failed child run. The test now waits for the child run to reach FAILED and the parent run to reach COMPLETED instead of stopping on any non-null status such as QUEUED or RUNNING.

Refs #4204

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Test changes (add, refactor, improve or change a test)

What's Changed

  • Wait for the durable child run to reach FAILED before asserting.
  • Wait for the durable parent run to reach COMPLETED before asserting.
  • Add poll labels so timeout messages identify which run status was pending.

Checklist

Changes have been:

  • Tested (unit, integration, or manually with steps specified)
  • Linted and formatted

Testing

  • pnpm exec prettier src/v1/examples/durable/durable.e2e.ts --check
  • pnpm exec eslint src/v1/examples/durable/durable.e2e.ts
  • pnpm exec tsc --noEmit
  • Not run: database-backed pnpm test:e2e, per local DB safety constraints. CI should cover the TypeScript test-e2e and old-engine-new-sdk jobs.

🤖 AI Disclosure
  • I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.

  • Details: Used Cursor agent and a Composer subagent to update the durable e2e polling predicates and run static TypeScript checks.

@igor-kupczynski igor-kupczynski added the ci-health CI/test reliability work tracked by the CI Health Dashboard label Jun 19, 2026
@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hatchet-docs Ready Ready Preview, Comment Jun 19, 2026 10:31am

Request Review

@github-actions github-actions Bot added the sdk-ts Related to the Typescript SDK label Jun 19, 2026
@igor-kupczynski
igor-kupczynski marked this pull request as ready for review June 19, 2026 12:33
@igor-kupczynski
igor-kupczynski merged commit 99dc0c1 into main Jun 19, 2026
19 checks passed
@igor-kupczynski
igor-kupczynski deleted the stabilize-typescript-durable-polling branch June 19, 2026 12:54
@github-actions github-actions Bot mentioned this pull request Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-health CI/test reliability work tracked by the CI Health Dashboard sdk-ts Related to the Typescript SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants