Optimize mtp tensor process by compiling layer names once for all - #1554
Merged
Conversation
Signed-off-by: Xin He <xin3.he@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets performance bottlenecks in copy_missing_tensors_from_source / WOQ handling by reducing repeated regex compilation and improving observability during long-running missing-tensor copy + (optional) FP8 dequant + WOQ steps.
Changes:
- Adds optional tqdm progress bars for loading missing tensors, FP8 dequantization, and WOQ quantization loops.
- Improves logging by summarizing involved parent layer names (compressed numeric ranges).
- Optimizes WOQ per-layer override resolution by pre-compiling regex patterns once and caching resolved layer configs.
You can also share your feedback on Copilot code review. Take the survey.
wenhuach21
reviewed
Mar 17, 2026
wenhuach21
reviewed
Mar 17, 2026
wenhuach21
reviewed
Mar 17, 2026
wenhuach21
self-requested a review
March 17, 2026 07:04
wenhuach21
approved these changes
Mar 17, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Xin He <xin3.he@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Got report that mtp process uses 10min for name matching and 5 min for WOQ [GLM-5]
Now the time usage reduces from 15min to 1min
Type of Change
Related Issues
Fixes or relates to #
Checklist Before Submitting