Skip to content

fix amp - #1767

Merged
wenhuach21 merged 4 commits into
mainfrom
wenhuach21-patch-2
May 8, 2026
Merged

fix amp#1767
wenhuach21 merged 4 commits into
mainfrom
wenhuach21-patch-2

Conversation

@wenhuach21

Copy link
Copy Markdown
Contributor

Description

Please briefly describe your main changes, the motivation.

Type of Change

Bug fix

Related Issues

Fixes or relates to #

Checklist Before Submitting

  • My code has been tested locally.
  • Documentation has been updated as needed.
  • New or updated tests are included where applicable.
  • The CUDA CI has passed. You can trigger it by commenting /azp run Unit-Test-CUDA-AutoRound.

Copilot AI review requested due to automatic review settings April 29, 2026 08:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes AMP autocast context selection in _get_loss_ext so autocast is enabled only when AMP is requested.

Changes:

  • Corrected the conditional that selects between autocast(...) and nullcontext() based on self.amp.

@wenhuach21 wenhuach21 changed the title Update alg_ext.py fix amp May 8, 2026
@wenhuach21

Copy link
Copy Markdown
Contributor Author

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wenhuach21
wenhuach21 merged commit 6add4c2 into main May 8, 2026
41 checks passed
@wenhuach21
wenhuach21 deleted the wenhuach21-patch-2 branch May 8, 2026 13:38
lvliang-intel pushed a commit that referenced this pull request May 12, 2026
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants