Add UV_PROCESS_WINDOWS_HIDE to avoid consoles on Windows - #627
Add UV_PROCESS_WINDOWS_HIDE to avoid consoles on Windows#627shanewholloway wants to merge 1 commit into
Conversation
…dows when launching subprocesses on Windows platforms. (port to v0.9 line)
|
I'm fine with this. Can you sign the CLA? http://nodejs.org/cla.html |
|
Fantastic! CLA signed & submitted. Do I need to port this to the 0.9 branch? |
|
Landed (with some style modifications and fixing an assertion on unix) in 5d92ccc. @shanewholloway PS. you may want to configure your git username, you show up as |
|
@piscisaureus thanks for letting me know — it is fixed for the future. |
|
Em, one question. |
|
When I was writing it, I was more concerned about not changing any existing behavior — SW_SHOWDEFAULT is the default behavior for Win32's CreateProcess. Making HIDE the default makes great sense based on your argument. |
The existing UV_PROCESS_WINDOWS_HIDE flag only applies to executables linked to the WINDOWS subsystem. This allows CONSOLE subsystem applications to pop up a console window. This commit sets the CREATE_NO_WINDOW process flag when UV_PROCESS_WINDOWS_HIDE to prevent this behavior. Refs: nodejs/node#15380 Refs: joyent/libuv#627 Refs: libuv#965 PR-URL: libuv#1558 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
3 participants
UV_PROCESS_WINDOWS_HIDE enables supression of process windows when launching subprocesses on Windows platforms from a executable linked to the WINDOWS subsystem (as opposed to the CONSOLE subsystem).