fix: do not add a newline to an empty code block - #4073
Merged
UziTech merged 2 commits intoSep 4, 2026
Conversation
Renderer.code appended a newline unconditionally, so a code block with no content rendered as <pre><code>\n</code></pre> instead of <pre><code></code></pre>. This fixes CommonMark examples 126, 130, 144 and 237. The spec suite did not catch it because htmlIsEqual leaves html-differ's ignoreWhitespaces at its default of true, and whitespace inside pre/code is significant, so all four were already reported as passing.
|
@Kjubikstronk is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Aug 30, 2026
UziTech
requested changes
Sep 3, 2026
UziTech
left a comment
Member
There was a problem hiding this comment.
move tests to test/specs/new with renderExact
Uses renderExact so the fixture compares exactly, which htmlIsEqual does not, and keeps the assertions out of marked.test.js.
Contributor
Author
|
Moved to One fixture covers all four cases. The unclosed fence has to come last since it runs to EOF. Reverting the renderer change fails it, so it has teeth. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
styfle
approved these changes
Sep 4, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
## [18.0.12](v18.0.11...v18.0.12) (2026-09-07) ### Bug Fixes * allow a tab before the closing sequence of an ATX heading ([#4084](#4084)) ([4417582](4417582)) * allow one more level of nested brackets in a link label ([#4064](#4064)) ([37b28d8](37b28d8)) * do not add a newline to an empty code block ([#4073](#4073)) ([23b1706](23b1706)) * escape character references in autolink destinations ([#4053](#4053)) ([8f432f0](8f432f0)) * reject GFM email autolink when the domain ends in _ or - ([#4063](#4063)) ([df57534](df57534)) * reject invalid characters in HTML tag names ([#4083](#4083)) ([300bb1d](300bb1d)) * remove up to the fence indentation from each content line ([#4074](#4074)) ([0244f08](0244f08))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 18.0.11 (53cb13f)
Markdown flavor: CommonMark
Description
Renderer.codeappends a newline unconditionally:For a code block with no content that turns
''into'\n', so an empty fence renders as<pre><code>\n</code></pre>instead of<pre><code></code></pre>.The lexer is not involved.
new Lexer({gfm: false}).lex('```\n')already givestext: ''.Expectation