You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes inconsistent behavior in Azure Search where index creation succeeded with DateType/TimestampType columns but data writing failed due to schema parity check expecting StringType.
Changes:
Add automatic date/timestamp to ISO8601 conversion in prepareDF method
Handle TimestampType with UTC conversion before formatting
Will help you set up a local build to make your life easier. You seem like a great dev and we are happy to take whatever fixes you would like to make to this code so long as we can get the builds green!
LGTM and build has passed, please megre your changes and well make sure it stays green Denniz Svens (@DennizSvens) before final merges. Thanks for your work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Fixes #2380
What changes are proposed in this pull request?
Fixes inconsistent behavior in Azure Search where index creation succeeded with DateType/TimestampType columns but data writing failed due to schema parity check expecting StringType.
Changes:
prepareDFmethodedmTypeToSparkTypemapping:Edm.DateTimeOffset→DateType(wasStringType)This eliminates the previous two-step workflow where users had to manually convert dates to strings after initial index creation.
How is this patch tested?
Tests added:
test("Handle date fields correctly")- Basic date/timestamp handling with null valuestest("Date field conversion handles different timezones correctly")- Timezone conversion scenariosEdm.DateTimeOffsetfield typesDoes this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?