fix: support scoring profiles in Azure Search index parsing - #2383
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2383 +/- ##
==========================================
- Coverage 84.63% 84.61% -0.03%
==========================================
Files 331 331
Lines 17194 17201 +7
Branches 1513 1518 +5
==========================================
+ Hits 14553 14555 +2
- Misses 2641 2646 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your contribution, only style has failed [error] /home/vsts/work/1/s/cognitive/src/test/scala/com/microsoft/azure/synapse/ml/services/search/SearchWriterSuite.scala:743:0: Whitespace at end of line Please run stylechecker locally with sbt scalastyle test:scalastyle to get a local repro |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
Fixes #2382
What changes are proposed in this pull request?
Fixes
DeserializationExceptionwhen writing data to Azure Search indices that contain scoring profiles. The JSON parser was expecting scoring profiles to be simple strings but Azure Search returns complex JSON objects.Changes:
ScoringProfile,ScoringFunction, etc.) inAzureSearchSchemas.scalaIndexInfo.scoringProfilestype fromOption[Seq[String]]toOption[Seq[ScoringProfile]]AzureSearchProtocolThis allows users to write data to Azure Search indices that have scoring profiles configured, which is common in production scenarios for relevance tuning.
How is this patch tested?
Tests added:
test("Handle Azure Search index with scoring profiles")- Verifies parsing of index JSON containing scoring profilesDeserializationExceptionis thrown when parsing scoring profilesDoes this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?