feat: Add top_p and seed params to OpenAIDefaults - #2410
Merged
Mark Hamilton (mhamilton723) merged 16 commits intoAug 7, 2025
Merged
Conversation
Introduces support for setting, getting, and resetting 'seed' and 'top_p' parameters in OpenAIDefaults for both Python and Scala. Adds input validation for 'temperature' (0.0-2.0) and 'top_p' (0.0-1.0) in both languages. Updates tests to cover new parameters and validation logic.
Rana Singh (ranadeepsingh)
requested a review
from Mark Hamilton (mhamilton723)
as a code owner
August 5, 2025 18:26
5 tasks
Rana Singh (ranadeepsingh)
changed the title
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2410 +/- ##
==========================================
- Coverage 84.48% 84.45% -0.04%
==========================================
Files 332 332
Lines 17251 17271 +20
Branches 1552 1555 +3
==========================================
+ Hits 14575 14586 +11
- Misses 2676 2685 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mark Hamilton (mhamilton723)
suggested changes
Aug 5, 2025
Mark Hamilton (mhamilton723)
left a comment
Mark Hamilton (mhamilton723)
left a comment
Contributor
There was a problem hiding this comment.
Amazing, minor Qs
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Mark Hamilton (mhamilton723)
merged commit Aug 7, 2025
7c2f22a
into
microsoft:master
67 of 70 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Close #2407
Close #2408
What changes are proposed in this pull request?
Add pass through new parameters that can be configured for openai chat.compleitions calls
How is this patch tested?
Added tests to check for updates
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
Added exmaples in Jupyter Notebook here
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.