fix: Make TranslateSuite resilient to API translation changes - #2491
Merged
Conversation
|
Hey Brendan Walsh (@BrendanWalsh) 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
Brendan Walsh (BrendanWalsh)
force-pushed
the
brwals/fix-translate-test
branch
2 times, most recently
from
February 6, 2026 04:16
586d2fd to
413e4cd
Compare
Brendan Walsh (BrendanWalsh)
changed the title
Replace ambiguous greetings ('Bye', 'Good morning') with the concrete
noun 'elephant' which has stable, unambiguous translations across
languages (大象, Elefant, éléphant).
Changes:
- 'Translate to multiple languages': uses round-trip assertion
(en→zh/de→en) instead of asserting specific foreign strings
- 'Translate multiple pieces of text': uses 'elephant'/'volcano'
with round-trip verification
- 'Translate with transliteration': asserts '大象'/'dàxiàng'
- 'Obtain alignment/sentence boundaries': uses 'elephant'→fr
('éléphant', 8 chars) instead of 'Bye'→'Au revoir' (9 chars)
This avoids whack-a-mole fixes every time the translation API model
shifts between valid synonyms (e.g. Wiedersehen vs Tschüss).
Brendan Walsh (BrendanWalsh)
force-pushed
the
brwals/fix-translate-test
branch
from
February 6, 2026 04:43
413e4cd to
15ccfec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
TranslateSuitetests assert specific translated strings (e.g. "Wiedersehen", "Au revoir", "再见") from the Azure Translator API. When the API model updates and picks a different valid synonym (e.g. "Tschüss" instead of "Wiedersehen"), tests break. This has already required whack-a-mole fixes (adding|| "拜拜"\,|| "早安").Fix
Replace ambiguous greetings with "elephant" — a concrete noun with stable, unambiguous translations across languages (
大象,Elefant,éléphant). Use round-trip translation (en→foreign→en) to verify correctness without asserting specific foreign strings.Tests changed
再见/zàijiàn大象/dàxiàng再见+Wiedersehen||TschüssAu revoirléphantWhy "elephant"?
Tested against the Azure Translator API across 5 languages — it has exactly one translation per language and round-trips perfectly back to English. Unlike greetings, there are no valid synonyms.