Killing an (integrated) terminal doesn't terminate the processes started therein (OSX)

[taiya]

Environment data

• VS Code version: 1.25.1
• Extension version (available under the Extensions sidebar): 2018.7.0
• OS and version: OSX 10.13.6
• Python version (& distribution if applicable, e.g. Anaconda): 3.7.0
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
• Relevant/affected Python packages and their versions: N/A

Actual behavior

Killing a terminal from the VSCODE ui lets scripts executed therein running in the background

Expected behavior

Processes created within the (terminated) integrated terminal should be terminated.

Steps to reproduce

1. write a python script with an infinite loop
2. execute the script with "Run Python File in Terminal"
3. In the vscode UI, press "Kill Terminal" to close the terminal window
4. the python script keeps running in the background
5. (laptop fan starts spinning mercilessly)
6. (access OSX activity monitor to terminate python process manually)

[brettcannon]

This would be an issue with VS Code itself and not the extension.

[DonJayamanne]

Brett Cannon (@brettcannon)
Reopening, as the debugger needs to handle the necessary signal and kill the process. That's what happens when you're not debugging (i.e. closing the terminal kills the program being run in the terminal). I believe the signal is SIGHUP.

Related PTVSD issues:

• PVSD should kill process when SIGHUP event is received ptvsd#128
• Debugger not terminating when terminal is closed ptvsd#602

@ataiya

• Please could you provide the contents of your .vscode/launch.json file
• Please could you try using the experimental debugger. Open the .vscode/launch.json file and change the setting "type":"python" to "type":"pythonExperimental"

[taiya]

Note I am not talking about the debugger.
I am talking about the standard "run in terminal" (might apply to debugger too though)
Will check your 2nd point in a jiffy

projectfolder/.vscode/launch.json (do not have one in ~/.vscode)

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python",
            "type": "python",
            "request": "launch",
            "stopOnEntry": false,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${file}",
            "cwd": "${workspaceFolder}",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput"
            ]
        },
        {
            "name": "Python: Attach",
            "type": "python",
            "request": "attach",
            "localRoot": "${workspaceFolder}",
            "remoteRoot": "${workspaceFolder}",
            "port": 3000,
            "secret": "my_secret",
            "host": "localhost"
        },
        {
            "name": "Python: Terminal (integrated)",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${file}",
            "cwd": "",
            "console": "integratedTerminal",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": []
        },
        {
            "name": "Python: Terminal (external)",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${file}",
            "cwd": "",
            "console": "externalTerminal",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": []
        },
        {
            "name": "Python: Django",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${workspaceFolder}/manage.py",
            "cwd": "${workspaceFolder}",
            "args": [
                "runserver",
                "--noreload",
                "--nothreading"
            ],
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput",
                "DjangoDebugging"
            ]
        },
        {
            "name": "Python: Flask (0.11.x or later)",
            "type": "python",
            "request": "launch",
            "stopOnEntry": false,
            "pythonPath": "${config:python.pythonPath}",
            "program": "fully qualified path fo 'flask' executable. Generally located along with python interpreter",
            "cwd": "${workspaceFolder}",
            "env": {
                "FLASK_APP": "${workspaceFolder}/quickstart/app.py"
            },
            "args": [
                "run",
                "--no-debugger",
                "--no-reload"
            ],
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput"
            ]
        },
        {
            "name": "Python: Flask (0.10.x or earlier)",
            "type": "python",
            "request": "launch",
            "stopOnEntry": false,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${workspaceFolder}/run.py",
            "cwd": "${workspaceFolder}",
            "args": [],
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput"
            ]
        },
        {
            "name": "Python: PySpark",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "osx": {
                "pythonPath": "${env:SPARK_HOME}/bin/spark-submit"
            },
            "windows": {
                "pythonPath": "${env:SPARK_HOME}/bin/spark-submit.cmd"
            },
            "linux": {
                "pythonPath": "${env:SPARK_HOME}/bin/spark-submit"
            },
            "program": "${file}",
            "cwd": "${workspaceFolder}",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput"
            ]
        },
        {
            "name": "Python: Module",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config:python.pythonPath}",
            "module": "module.name",
            "cwd": "${workspaceFolder}",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput"
            ]
        },
        {
            "name": "Python: Pyramid",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config:python.pythonPath}",
            "cwd": "${workspaceFolder}",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "args": [
                "${workspaceFolder}/development.ini"
            ],
            "debugOptions": [
                "RedirectOutput",
                "Pyramid"
            ]
        },
        {
            "name": "Python: Watson",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${workspaceFolder}/console.py",
            "cwd": "${workspaceFolder}",
            "args": [
                "dev",
                "runserver",
                "--noreload=True"
            ],
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput"
            ]
        }
    ]
}

[taiya]

Regarding your second point, I changed project/.vscode/launch.json as follows, but without any effect.

        {
            "name": "Python: Terminal (integrated)",
            "type": "pythonExperimental",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${file}",
            "cwd": "",
            "console": "integratedTerminal",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": []
        },

[taiya]

However, I have also noticed that the following program does not create a problem:

while(True):
   pass

While with some text I/O my (4 core) CPU is saturated ~90% (after closing the integrated terminal, clearly)

while(True):
   print('buggy bug')

[DonJayamanne]

While with some text I/O my (4 core) CPU is saturated ~90% (after closing the integrated terminal, clearly)

Not the best test, your CPU would be saturated irrespective.

Can you test with a simple sleep and file I/O as the following:

import time
import os

i = 1
with open ('log.log') as fs:
    I += 1
    fs.write('line {} in process {}'.format(i, os.getpid()))
    fs.flush()
    time.sleep(0.5)

Please use this code to confirm the process is still running in the background by either checking whether the file is still being written to or checking the existence of the proc.

Please test using the Experimental debugger.
It should work. Works at my end using a Mac on Python 3.7.

[taiya]

Hi Don Jayamanne (@DonJayamanne) a few notes:

Not the best test, your CPU would be saturated irrespective.

yes, it's just with "pass" nothing was showing up in my top CPU cloggers

Please use this code to confirm the process is still running ...

1. not exactly sure why this is relevant? I cannot close the terminal window before this process terminates. Do you instead mean something like this? In any case, killing the integrated terminal on this one DOES indeed kill the process (checked file).

import time
import os
while True:
    i = 1
    with open('log.log','a+') as fs:
        i += 1
        fs.write('line {} in process {}\n'.format(i, os.getpid()))
        fs.flush()
        time.sleep(0.5)

2. Please test using the Experimental debugger
   not sure how to enable it, or why it'd be relevant here?

[brettcannon]

@ataiya change your launch.json to have "type": "pythonExperimental" and it's relevant because Don Jayamanne (@DonJayamanne) is trying to solve the debugger case as that's technically the supported way to execute a program in VS Code, debugging or not.

[taiya]

Hi Brett Cannon (@brettcannon), ah! I see what you mean now (regarding default execute mode)

When I "start without debugging" even when I click the "kill terminal" the toolbar with the debugger actions remains alive (so I can kill the process from there, no problem). This is irrespective of whether "python" or "pythonExperimental" is selected -- so I am not sure what you want me to check. That considered, the "bug" seems indeed more relevant to basic vscode.

However, a couple of notes:

• Once I close the terminal there is no way of re-opening it, even if the process is still running (which is a bit counter-intuitive? killing an iTerm would kill any process started therein)
• Since the "Python: Run Python file in Terminal" is distributed by this vscode extension. If the default way of executing python is through the debugger, shouldn't this command be hardwired to do that? This feels a bit odd right now.