Unittest top-level-directory option - #19398
Merged
Karthik Nadig (karthiknadig) merged 4 commits intoJul 14, 2022
Merged
Conversation
|
|
Karthik Nadig (karthiknadig)
self-requested a review
July 7, 2022 18:18
Karthik Nadig (karthiknadig)
added
the
bug
Author
|
Reviewed the testing page on the wiki, the edited TS files are not currently part of any test suite. Please advise |
Member
|
Darren Fuller (@dazfuller) I have cleared the check for you. No worries. |
Anthony Kim (anthonykim1)
approved these changes
Jul 10, 2022
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* update unittest discovery to work with user defined top-level-directory * change to make top-level-dir optional * add top-level-dir to unittest run args * update test discovery to use top-level-directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to issues #5721 and #6881 and adds support for the
-t/--top-level-directoryargument for test discovery when using unittest.The following changes have been made.
unittestGetTopLevelDirectoryto get top level directory value from options--utoption already available in thevisualstudio_py_testlauncher.pyscriptThe import cleanup in the python files was done automatically by pylance.