Skip to content

fix incorrect option code when serializing Capwap_ac_v4 option - #53

Merged
haesbaert merged 1 commit into
mirage:masterfrom
yomimono:fix-capwap
Apr 8, 2017
Merged

fix incorrect option code when serializing Capwap_ac_v4 option#53
haesbaert merged 1 commit into
mirage:masterfrom
yomimono:fix-capwap

Conversation

@yomimono

@yomimono yomimono commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@haesbaert
haesbaert merged commit 378df71 into mirage:master Apr 8, 2017
@haesbaert

Copy link
Copy Markdown
Member

Merged, I've commited a line by line copyrights since I prefer that format, also added you to dhcp_wire.ml and test.ml, please let me know if this is ok.

I don't really know what's the norm on the ocaml community concerning copyrights.
I'm used to add myself to a file when I've done "enough" (I think this is a UNIX tradition thingy), and keep track of copyrights on a file by file basis. So if anyone wants to relicense some day, they need to contact every author of every file.

@yomimono

Copy link
Copy Markdown
Contributor Author

I also don't really know what the norm is concerning copyrights; I've pretty much been putting my name in stuff that I write, and if someone else adds me to something that I worked on a lot, that's fine. I have banner blindness for top-of-file copyrights and I have to admit I didn't even notice that there were any in this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants