Checkboxlist in combination with a persistent parameter, never clear value.

[h4kuna]

Version: 2.4.7

Bug Description

If you use UI\Form method="get", add checkboxlist with name list and set property $list in presenter like persistent. You never reset form. You must only remove parameters from url.

Steps To Reproduce

• download sandbox
• Presenter app/presenters/FormPresenter.php

<?php

namespace App\Presenters;

use Nette\Application\UI\Form;

class FormPresenter extends BasePresenter
{

	/**
	 * @persistent
	 */
	public $list = [];

	protected function createComponentForm()
	{
		$form = new Form();
		$form->setMethod($form::GET);
		$form->addCheckboxList('list', 'List', ['Foo', 'Bar', 'Doe', 'Joe']);
		$form->addSubmit('filter', 'Filter');
		return $form;
	}
}

• template app/presenters/templates/Form/default.latte

{block content}
{control form}

• open url http://localhost:8000/form/
• click on checkbox Foo, send form
• uncheck Foo, send form and checkbox is still checked
  In form is added hidden input

<input type="hidden" name="list[0]" value="0">

And checkbox list is genereted like:

<input type="checkbox" name="list[]" checked="" value="0">

If check all checkboxes and submit form moretimes, you can see many hidden inputs in form.

Expected Behavior

Is described above

Possible Solution

For this moment I use Nette\Forms\Form for filter form, where i don't need events, but i need to make manually a bool value.

[h4kuna]

I found bug in DefaultFormRenderer.php:176 because variable $name has value list[0] this is not contained in form components.

[dg]

What about append line $name = explode('[', $name, 2)[0];

[h4kuna]

Yes, this is possible, I try preg_replace('#\[.*#', '', $name), but i can not image what happen in this case.

$list = $form->addContainer('list');
$list->addCheckboxList('foo', 'List', ['Foo', 'Bar', 'Doe', 'Joe']);

In $name variable is list[foo][0].

If we want check only first level, this solution is possible. Is need check more levels?

[dg]

IMHO first level is enough.

[h4kuna]

Ok I prepare PR until the end of the week.