flaky test-debugger-debug-brk

[BridgeAR]

https://ci.nodejs.org/job/node-test-commit-linux/15863/nodes=debian8-64/console

not ok 2017 sequential/test-debugger-debug-brk
  ---
  duration_ms: 0.172
  severity: fail
  stack: |-
    assert.js:72
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: '/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/out/Release/node --inspect --debug-brk /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/fixtures/empty.js' should not quit
        at ChildProcess.fail (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/sequential/test-debugger-debug-brk.js:19:29)
        at ChildProcess.emit (events.js:131:13)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
  ...

not ok 2044 sequential/test-inspector-async-hook-setup-at-signal
  ---
  duration_ms: 120.10
  severity: fail
  stack: |-
    timeout

not ok 2053 sequential/test-inspector-enabled
  ---
  duration_ms: 0.172
  severity: fail
  stack: |-
    Starting inspector on 127.0.0.1:9229 failed: address already in use

The two latter errors should be follow errors and there are more when looking at the output of that build.

[MylesBorins]

Happened again

https://ci.nodejs.org/job/node-test-commit-linux/15944/nodes=debian8-64/console

[apapirovski]

The most likely culprit here seems to be the V8 upgrade. This started failing shortly after that was pushed to master. The fact that it only seems to fail on one system isn't super helpful as far as debugging :(

[Trott]

sequential/test-debugger-debug-brk began failing for me locally on macOS and I couldn't figure out why for a few minutes.

Then I realized that there was a stale test process.

There is something in the Makefile that is supposed to terminate processes like that in CI, but perhaps it's not successfully terminating the process. Logging into test-rackspace-debian8-x64-1, sure enough there are week-old processes that need to be terminated. It was not being terminated because it was not originally from test-node-commit or whatever, so it isn't using the node that is being looked for (with Release in the path).

I just terminated the process. I bet this platform starts working now.

root@test-rackspace-debian8-x64-1:/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64# ./node test/sequential/test-debugger-debug-brk.js 
assert.js:72
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: '/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/out/Release/node --inspect --debug-brk /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/fixtures/empty.js' should not quit
    at ChildProcess.fail (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/sequential/test-debugger-debug-brk.js:19:29)
    at ChildProcess.emit (events.js:131:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
root@test-rackspace-debian8-x64-1:/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64# /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/out/Release/node --inspect --debug-brk /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/fixtures/empty.js
Starting inspector on 127.0.0.1:9229 failed: address already in use
root@test-rackspace-debian8-x64-1:/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64# ps -ef | grep 9229
root     14713 14491  0 05:28 pts/0    00:00:00 grep 9229
iojs     29220     1  0 Jan24 ?        00:00:00 /home/iojs/build/workspace/node-inspect-continuous-integration/MACHINE/debian8-64/node-v7.9.0-linux-x64/bin/node --inspect --debug-brk=9229 examples/backtrace.js
root@test-rackspace-debian8-x64-1:/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64# kill 29220
root@test-rackspace-debian8-x64-1:/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64# ps -ef | grep 9229
root     14768 14491  0 05:29 pts/0    00:00:00 grep 9229
root@test-rackspace-debian8-x64-1:/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64#

/cc @nodejs/build

[Trott]

First green CI on that host in a long time. https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian8-64/16016/console

Closing.

[apapirovski]

This is what happens when someone doesn't read far enough up the page... Ignore me @Trott. 😆

[apapirovski]

@Trott failed again today on https://ci.nodejs.org/job/node-test-commit-linux/16052/nodes=ubuntu1604-32/tapResults/ — could you have a look by any chance and see if the fix above applies here too?

[Trott]

Unless someone or something else fixed it in the intervening 8 hours, it was something else. Since subsequent inspector tests didn't also fail, that's also a sign this is a different cause.