Skip to content

test: benchmark/test-benchmark-os fails on IBM i #50207

Description

@abmusse

CI: https://ci.nodejs.org/job/node-test-commit-ibmi/1332/nodes=ibmi73-ppc64/testReport/(root)/benchmark/test_benchmark_os/

test-benchmark-os.js now includes an os.uptime benchmark.

For reference, this commit adds the uptime benchmark: 0f0dd1a

This test fails is due to the fact that os.uptime returns enosys on IBM i.

https://github.com/libuv/libuv/blame/dc1bb0088e8fbb92c81beb55341dcb7b4079717f/src/unix/ibmi.c#L283

Welcome to Node.js v20.5.1.
Type ".help" for more information.
> require('os').uptime()
Uncaught:
SystemError [ERR_SYSTEM_ERROR]: A system error occurred: uv_uptime returned ENOSYS (function not implemented)
    at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)
    at new SystemError (node:internal/errors:256:5)
    at new NodeError (node:internal/errors:367:7)
    at Object.__node_internal_checkError [as uptime] (node:os:68:13) {
  code: 'ERR_SYSTEM_ERROR',
  info: {
    errno: -109,
    code: 'ENOSYS',
    message: 'function not implemented',
    syscall: 'uv_uptime'
  },
  errno: [Getter/Setter: -109],
  syscall: [Getter/Setter: 'uv_uptime']
}

We would need to find a way to skip this uptime benchmark individually (on IBM i) if possible. Otherwise we may need to disable running the test-benchmark-os.js in the meantime (on IBM i).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.ibm iIssues and PRs related to the IBM i platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions