V8 patch update workflow is broken

[targos]

See https://github.com/nodejs/node/actions/runs/6680065519/job/18152806998

It's not clear why it fails. There's no error message in the output.

/cc @marco-ippolito

[marco-ippolito]

Could it be a timeout?
It's failing consistently
cc @nodejs/security-wg

[targos]

Note it doesn't fail on my computer:

$ ./tools/dep_updaters/update-v8-patch.sh
Skipped because V8 is on the latest version.

[targos]

Yes, it's been failing consistently for some time.
Here are the commits between the last successful run and the first failure: 718f62b...ff14b24

[marco-ippolito]

Note it doesn't fail on my computer:

$ ./tools/dep_updaters/update-v8-patch.sh
Skipped because V8 is on the latest version.

same for me, I can create a branch and remove the pipe to temp output so we should see in the action as it runs

./tools/dep_updaters/update-v8-patch.sh > temp-output

[marco-ippolito]

https://github.com/nodejs/node/actions/runs/6717612045/job/18255788737
with this change (./tools/dep_updaters/update-v8-patch.sh > temp-output), it works 🤔
main...do-not-merge/fix-update-v8-action

[targos]

Can you try again with echo statements between each line so we have an idea about when it fails?

[marco-ippolito]

now it worked on main 🤔
https://github.com/nodejs/node/actions/workflows/update-v8.yml
that's 100% weird, on other branch it worked fine too
could be git node v8 minor failing network calls?

[aduh95]

Could be related to nodejs/node-core-utils#722 😞

[targos]

Not sure. It's been failing consistently since June.

[targos]

Now there's an update and it fails: https://github.com/nodejs/node/actions/runs/6945894914/job/18896335828

[marco-ippolito]

@targos should we add some logging to the script/action?

[targos]

Probably.

[marco-ippolito]

@nodejs/node-core-utils
maybe related to nodejs/node-core-utils#743, it also fails for git node v8 minor
The fails seems not to be consistent anymore but using a previous version 3.3.0 gives an output
https://github.com/nodejs/node/actions/runs/7016406093/job/19087566216
while using >4.0.0 no error message

[targos]

Ok, so the ncu bug is that it swallows the error message.
The problem of the workflow is that it doesn't set Git name and email before running the update script.