Skip to content

streamResetBurst and streamResetRate options are missing in the documentation of http2.createSecureServer #57169

Description

@gunters63

Affected URL(s)

https://nodejs.org/docs/latest/api/http2.html#http2createsecureserveroptions-onrequesthandler

Description of the problem

The new options were added in Node 18.18.2, 20.8.1 und 21.0 to mitigate RST attacks.
It is documented for http2.createServer, but missing in http2.createSecureServer.

I am pretty sure it works for both, because the way createServer and createSecureServer share the code handling the options. It also makes absolutely no sense for them to work for createServer and not for createSecureServer.

The Typescript typings are also wrong. Only createServer typings recognizes streamResetBurst and streamResetRate. If I want to use them for createSecureServer, i have to supress typescript errors for this line and then it seems to work.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.http2Issues and PRs related to the http2 subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions