Skip to content

tools: simplify lowercase-name-for-primitive rule - #17653

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:lint
Dec 15, 2017
Merged

tools: simplify lowercase-name-for-primitive rule#17653
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:lint

Conversation

@cjihrig

@cjihrig cjihrig commented Dec 13, 2017

Copy link
Copy Markdown
Contributor
  • Use an AST selector instead of handwritten function.
  • Move functions up a scope level.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 13, 2017
maclover7
maclover7 approved these changes Dec 13, 2017
View reviewed changes

@maclover7 maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7

maclover7 commented Dec 13, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12089/

@BridgeAR BridgeAR added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Dec 13, 2017
@cjihrig

cjihrig commented Dec 15, 2017

Copy link
Copy Markdown
Contributor Author

New CI run: https://ci.nodejs.org/job/node-test-pull-request/12128/

@cjihrig
tools: simplify lowercase-name-for-primitive rule
203ce5f 
PR-URL: nodejs#17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@cjihrig
cjihrig merged commit 203ce5f into nodejs:master Dec 15, 2017
@cjihrig
cjihrig deleted the lint branch December 15, 2017 16:21
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@cjihrig @MylesBorins
tools: simplify lowercase-name-for-primitive rule
eaa2d91 
PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@cjihrig @MylesBorins
tools: simplify lowercase-name-for-primitive rule
de5130d 
PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@cjihrig @MylesBorins
tools: simplify lowercase-name-for-primitive rule
57e4cfd 
PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@cjihrig @gibfahn
tools: simplify lowercase-name-for-primitive rule
59def2a 
PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@cjihrig @MylesBorins
tools: simplify lowercase-name-for-primitive rule
244d569 
PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@cjihrig @MylesBorins
tools: simplify lowercase-name-for-primitive rule
4553859 
PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@cjihrig @MylesBorins
tools: simplify lowercase-name-for-primitive rule
928b7c8 
PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+2 more reviewers
@apapirovski apapirovski apapirovski approved these changes
@maclover7 maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cjihrig @maclover7 @apapirovski @jasnell @lpinca @BridgeAR @MylesBorins @addaleax @nodejs-github-bot