test: fix flaky sequential/test-fs-watch-system-limit - #23038
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
This test has at least once locally received `EMFILE` rather than `ENOSPC`, which also seems to provide a reasonable error message (which is what the test ultimately checks).
addaleax
added
fs
nodejs-github-bot
added
the
test
targos
approved these changes
Sep 23, 2018
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/17385/ Please 👍 this comment to approve fast-tracking. |
addaleax
added
fast-track
lpinca
approved these changes
Sep 23, 2018
Member
Author
|
Landed in bea41bc |
addaleax
added a commit
that referenced
this pull request
Sep 23, 2018
This test has at least once locally received `EMFILE` rather than `ENOSPC`, which also seems to provide a reasonable error message (which is what the test ultimately checks). PR-URL: #23038 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 24, 2018
This test has at least once locally received `EMFILE` rather than `ENOSPC`, which also seems to provide a reasonable error message (which is what the test ultimately checks). PR-URL: #23038 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has at least once locally received
EMFILEratherthan
ENOSPC, which also seems to provide a reasonable errormessage (which is what the test ultimately checks).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes