Skip to content

test: update web-platform tests for url - #46860

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
meixg:url-quote-escape
Mar 1, 2023
Merged

test: update web-platform tests for url#46860
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
meixg:url-quote-escape

Conversation

@meixg

@meixg meixg commented Feb 27, 2023

Copy link
Copy Markdown
Member

Update wpt url test. Added case for #46850 by web-platform-tests/wpt#38711.

Rely on #46853

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Feb 27, 2023
@anonrig

anonrig commented Mar 1, 2023

Copy link
Copy Markdown
Member

Can you update the pull request @meixg? The tests are failing of it.

@meixg
meixg force-pushed the url-quote-escape branch from 94c4683 to 10d8755 Compare March 1, 2023 01:49
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Mar 1, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f652f7b into nodejs:main Mar 1, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in f652f7b

@meixg
meixg deleted the url-quote-escape branch March 3, 2023 03:24
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants