WIP query - #27
Merged
Merged
Conversation
except obx_qb_link_property obx_qb_backlink_property obx_qb_link_standalone obx_qb_backlink_standalone
weird NPE issue
* Reused IDArray to read findIds values * Added generics to Query, QueryBuilder * Implement findIds
vaind
reviewed
Oct 9, 2019
vaind
left a comment
vaind
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I just had a few suggestions about structuring and simplifying the code.
vaind
reviewed
Oct 15, 2019
vaind
left a comment
vaind
left a comment
Contributor
There was a problem hiding this comment.
A few more comments, some I've ended up addressing in the PR related to OBX_id_array ffi struct. See Buggaboo#1
id-array FFI struct & TestEnv
no magic numbers
Conformed enums to dart-style
and reports 'libojbectbox.dylib' as missing
vaind
reviewed
Oct 17, 2019
This reverts commit 3cccbf3.
Streamline query any/all
Contributor
|
I've merged this, doing a couple of small changes in the process
|
Contributor
Author
|
Omg! Let's do a beer some time to celebrate. |
greenrobot-team
added a commit
that referenced
this pull request
Jan 31, 2024
Note: Flutter plugin method is only called on Android, also is a no-op on devices newer than Android 6 (API level M).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last hurdle: fixing the tests, take inspiration from the golang tests.