[TODO] service/server: note to remove override that will become useless - #29706
Closed
beledouxdenis wants to merge 1 commit into
Closed
[TODO] service/server: note to remove override that will become useless#29706beledouxdenis wants to merge 1 commit into
beledouxdenis wants to merge 1 commit into
Conversation
The method override `_handle_request_noblock` is there to solve a bug in Python socketserver library which has been solved in - Python 3.6: python/cpython@8b1f52b, - Python 3.7: python/cpython@9080824, through PR python/cpython#9952. These revisions will be included in Python releases 3.6.8 and 3.7.2, and the override will then become useless. We therefore can remove the `_handle_request_noblock` override as soon as the Python 3 releases installed on operating systems supported by Odoo are above - 3.6.8 for Python 3.6 - 3.7.2 for Python 3.7
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 21, 2018
The method override `_handle_request_noblock` is there to solve a bug in Python socketserver library which has been solved in - Python 3.6: python/cpython@8b1f52b, - Python 3.7: python/cpython@9080824, through PR python/cpython#9952. These revisions will be included in Python releases 3.6.8 and 3.7.2, and the override will then become useless. We therefore can remove the `_handle_request_noblock` override as soon as the Python 3 releases installed on operating systems supported by Odoo are above - 3.6.8 for Python 3.6 - 3.7.2 for Python 3.7 closes #29706
Contributor
|
Merged, thanks! |
ryv-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Nov 24, 2023
The TODO added in odoo#29706 is confusing and asks to remove the `_handle_request_noblock` method completely. In fact, the TODO only targets the first if of the method. Why the confusion? It was merged at the same time as odoo#37238, which reuses the same hook for a different feature. Remove the confusing comment, and the first `if` of the method, as the fix is in all supported Python versions (python/cpython@10cb376).
robodoo
pushed a commit
that referenced
this pull request
Nov 28, 2023
The TODO added in #29706 is confusing and asks to remove the `_handle_request_noblock` method completely. In fact, the TODO only targets the first if of the method. Why the confusion? It was merged at the same time as #37238, which reuses the same hook for a different feature. Remove the confusing comment, and the first `if` of the method, as the fix is in all supported Python versions (python/cpython@10cb376). closes #143297 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
BT-anieto
pushed a commit
to BT-anieto/odoo
that referenced
this pull request
Oct 30, 2024
Syncing from upstream odoo/odoo (17.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method override
_handle_request_noblockis there to solve a bug in Python socketserver library
which has been solved in
through PR python/cpython#9952.
These revisions will be included in Python releases 3.6.8 and 3.7.2,
and the override will then become useless.
We therefore can remove the
_handle_request_noblockoverrideas soon as the Python 3 releases installed on operating systems
supported by Odoo are above