feat(ffi): add async message iterator - #442
Merged
Merged
Conversation
Add a new V4 asynchronous message iterator. This mirrors the existing `pact_handle_get_sync_message_iter` and `pact_handle_get_http_iter`, and is the V4 counterpart for `pact_handle_get_message_iter`. I have not marked the `pact_handle_get_message_iter` as deprecated; however, if the functionality of the new iterator supplants the older `PactMessageIterator`, it may be worth documenting the deprecation and directing people to use the new function/iterator. Signed-off-by: JP-Ellis <josh@jpellis.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new V4 asynchronous message iterator. This mirrors the existing
pact_handle_get_sync_message_iterandpact_handle_get_http_iter, and is the V4 counterpart forpact_handle_get_message_iter.I have not marked the
pact_handle_get_message_iteras deprecated; however, if the functionality of the new iterator supplants the olderPactMessageIterator, it may be worth documenting the deprecation and directing people to use the new function/iterator.PS: I have not written tests for it, but it would appear that the other iterators don't have tests either.