Skip to content

Break html scan on eof - #438

Merged
raphlinus merged 1 commit into
masterfrom
fix_html_hang
Apr 6, 2020
Merged

Break html scan on eof#438
raphlinus merged 1 commit into
masterfrom
fix_html_hang

Conversation

@raphlinus

@raphlinus raphlinus commented Apr 6, 2020

Copy link
Copy Markdown
Collaborator

Fixes #437

marcusklaas
marcusklaas approved these changes Apr 6, 2020
View reviewed changes

@marcusklaas marcusklaas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@raphlinus
raphlinus merged commit 2b929de into master Apr 6, 2020
@tmiasko tmiasko mentioned this pull request Apr 7, 2020
Closed
@ehuss

ehuss commented Apr 29, 2020

Copy link
Copy Markdown
Contributor

@raphlinus Would it be possible to get a point release with this fix?

@sjackman

sjackman commented Apr 29, 2020

Copy link
Copy Markdown

I just ran into this bug. rustdoc 1.43.0 is affected by it. It hangs indefinitely on /// <b. A point release would be very much appreciated. Thank you @raphlinus for the fix.

raphlinus added a commit that referenced this pull request Apr 29, 2020
@raphlinus
Bump version for 0.7.1 release
4551d8f 
Will let us publish a release for #438
@raphlinus raphlinus mentioned this pull request Apr 29, 2020
Merged
@raphlinus
raphlinus deleted the fix_html_hang branch April 29, 2020 16:00
@raphlinus

raphlinus commented Apr 29, 2020

Copy link
Copy Markdown
Collaborator Author

The 0.7.1 release is now out, and includes this fix. Thanks for the interest!

phansch added a commit to phansch/rust-clippy that referenced this pull request Jun 1, 2020
@phansch
Add regression test for endless loop
861b897 
This was fixed in pulldown_cmark 0.7.1, specifically
pulldown-cmark/pulldown-cmark#438
@phansch phansch mentioned this pull request Jun 1, 2020
Merged
bors added a commit to rust-lang/rust-clippy that referenced this pull request Jun 1, 2020
@bors
Auto merge of #5673 - phansch:endless-loop, r=Manishearth
bfafb8e 
Add regression test for endless loop / update `pulldown_cmark`

Closes #4917

This was fixed in pulldown_cmark 0.7.1, specifically pulldown-cmark/pulldown-cmark#438

changelog: none
@raphlinus raphlinus mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcusklaas marcusklaas marcusklaas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hangs on unterminated html tag

4 participants

@raphlinus @ehuss @sjackman @marcusklaas