Skip to content

Miscellaneous fixes in Python/suggestions.c #106030

Description

@serhiy-storchaka
  • PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
    should not be used.
  • PyUnicode_CompareWithASCIIString() only works if the second argument
    is ASCII string.
  • Refleak in get_suggestions_for_name_error.
  • Use of borrowed pointer after possible freeing (self).
  • Add some missing error checks.

Linked PRs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions