Implement PEP 578

[zooba]

BPO	36842
Nosy	@vstinner, @tiran, @zooba, @pablogsal, @miss-islington
PRs	bpo-36842: Implement PEP 578 #12613 bpo-36842: Fix reference leak in tests by running out-of-proc #13556 bpo-36842: Pass positional only parameters to code_new audit hook #13707 bpo-37215: Fix dtrace issue introduce by bpo-36842 #13940 [3.8] bpo-37215: Fix dtrace issue introduce by bpo-36842 (GH-13940) #13942

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2019-05-29.15:29:33.940>
created_at = <Date 2019-05-07.20:48:32.769>
labels = ['type-feature', '3.8', '3.9']
title = 'Implement PEP 578'
updated_at = <Date 2020-04-14.23:05:24.286>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2020-04-14.23:05:24.286>
actor = 'vstinner'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2019-05-29.15:29:33.940>
closer = 'steve.dower'
components = []
creation = <Date 2019-05-07.20:48:32.769>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 36842
keywords = ['patch']
message_count = 11.0
messages = ['341819', '343304', '343312', '343315', '343414', '343419', '343891', '344217', '345131', '345133', '366461']
nosy_count = 5.0
nosy_names = ['vstinner', 'christian.heimes', 'steve.dower', 'pablogsal', 'miss-islington']
pr_nums = ['12613', '13556', '13707', '13940', '13942']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36842'
versions = ['Python 3.8', 'Python 3.9']

[zooba]

Implement PEP-578

[zooba]

New changeset b82e17e by Steve Dower in branch 'master':
bpo-36842: Implement PEP-578 (GH-12613)
b82e17e

[zooba]

test_gdb failed on the Debian PGO buildbot

https://buildbot.python.org/all/#builders/47/builds/2854

I'm going to do what I can to investigate, but I may be out of my depth here!

[vstinner]

I created bpo-37023 to track the test_gdb failure: "test_gdb failed on AMD64 Debian PGO 3.x".

[vstinner]

It seems like there are reference leaks:

https://buildbot.python.org/all/#/builders/1/builds/593

test_audit leaked [310, 310, 310] references, sum=930
test_audit leaked [189, 189, 189] memory blocks, sum=567

You may try test.bisect_cmd to debug this.

[zooba]

Since hooks can't be removed, it probably looks like a leak when some are added for the tests.

I'll update all the tests to run in new processes.

[zooba]

New changeset 9ddc416 by Steve Dower in branch 'master':
bpo-36842: Fix reference leak in tests by running out-of-proc (GH-13556)
9ddc416

[pablogsal]

New changeset 3b57f50 by Pablo Galindo in branch 'master':
bpo-36842: Pass positional only parameters to code_new audit hook (GH-13707)
3b57f50

[miss-islington]

New changeset 8a8b59c by Miss Islington (bot) (Christian Heimes) in branch 'master':
bpo-37215: Fix dtrace issue introduce by bpo-36842 (GH-13940)
8a8b59c

[miss-islington]

New changeset bac6e63 by Miss Islington (bot) in branch '3.8':
bpo-37215: Fix dtrace issue introduce by bpo-36842 (GH-13940)
bac6e63