align small malloc-allocations even less, and test that we do - #817
Merged
Conversation
This was referenced Jul 2, 2019
RalfJung
commented
Jul 3, 2019
| let p = libc::malloc(3); | ||
| let addr = p as usize; | ||
| let unaligned = addr % 4 != 0; // test that this is not 4-aligned | ||
| libc::free(p); // FIXME have to free *after* test; should allow ptr-to-int of dangling ptr. |
Member
Author
There was a problem hiding this comment.
Note: I should rebase before we land this; master will soon allow ptr-to-int for dangling pointers.
Contributor
|
☔ The latest upstream changes (presumably #825) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit 029a294 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jul 5, 2019
align small malloc-allocations even less, and test that we do Needs rust-lang/rust#62295 to land. Fixes #812.
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs rust-lang/rust#62295 to land.
Fixes #812.