Skip to content

Make macro_use_imports lint ordering more stable - #11782

Merged
bors merged 1 commit into
rust-lang:masterfrom
Alexendoo:macro-use-imports-ordering
Nov 19, 2023
Merged

Make macro_use_imports lint ordering more stable#11782
bors merged 1 commit into
rust-lang:masterfrom
Alexendoo:macro-use-imports-ordering

Conversation

@Alexendoo

Copy link
Copy Markdown
Member

changelog: none

Fixes the macro_use_imports ordering dependence on the hash of Spans

@rustbot

rustbot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

r? @Centri3

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 9, 2023

@Centri3 Centri3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

Comment thread clippy_lints/src/macro_use.rs
@Centri3

Centri3 commented Nov 19, 2023

Copy link
Copy Markdown
Member

Thanks, @bors r+

@bors

bors commented Nov 19, 2023

Copy link
Copy Markdown
Contributor

📌 Commit d8c0e64 has been approved by Centri3

It is now in the queue for this repository.

@bors

bors commented Nov 19, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit d8c0e64 with merge 9263f80...

@bors

bors commented Nov 19, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing 9263f80 to master...

@bors
bors merged commit 9263f80 into rust-lang:master Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants