Skip to content

Audit debug test runners to drop --test-args clang filters on run-make tests #132034

Description

@jieyouxu

Context

Only two CI jobs have RUSTBUILD_FORCE_CLANG_BASED_TESTS 1 set, which is a necessary condition for //@ needs-force-clang-based-tests run-make tests to run. These tests (at the time when this issue was opened) pass a --test-args clang filter to the run-make test suite, meaning only run-make tests with clang in their name will run. This is a footgun which meant that several //@ needs-force-clang-based-tests run-make tests never ran in any CI jobs.

Known test runners:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsC-bugCategory: This is a bug.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions