Tracking issue for RFC 1682: field init shorthand

[aturon]

RFC.

Before stabilizing:

• Needs documentation (document field init shorthand #38830)

[Havvy]

Once we have this syntax, we'll want to clean up the compiler where it's useful. Since this would be almost a rote cleanup, we'd either want a mentored issue or a tool to do it.

[steveklabnik]

a tool to do it.

I wonder if @killercup 's rustfix could do this

[eddyb]

@steveklabnik rustfmt doing it by default has also been mentioned. cc @nrc

[nrc]

Yeah, Rustfmt could def. do this.

[killercup]

I haven't read that RFC; if you can write a lint that suggests the new
syntax (with a concrete and valid code suggestion), rustfix will be able to
fix this. (If this is only a syntactic change though it might indeed make
more sense to add this to rustfmt.)

Eduard-Mihai Burtescu notifications@github.com schrieb am Sa. 22. Okt.
2016 um 09:54:

@steveklabnik https://github.com/steveklabnik rustfmt doing it by
default has also been mentioned. cc @nrc https://github.com/nrc

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#37340 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABOX5MshoHk0m8Wn4KIr1eC4p3DInQpks5q2cFCgaJpZM4KdxM6
.

[est31]

I think that the compiler shouldn't lint for this, suggesting sugar features is more a thing for clippy.

[chriskrycho]

What's the current status on this—in nightly, it looks like, via #11994? Do we know when it's expected to land?

[matthew-piziak]

@chriskrycho Confirmed—it works in nightly. I'm using the feature in my nightly project right now.

[Havvy]

The new documentation required RFC means we need to figure out how to document it, I think?

• The grammar needs updating
• as would adding a section to the book and the new book.
• The reference would need a paragraph explaining the sugar.
• Additionally, we may want to add examples to Rust By Example showing the syntax.

We also need changelog entries? I propose the following for the short entry. I don't have the energy right now to try a long entry.

Added field init shorthand syntax when the field and variable names match.

[matthew-piziak]

Rustfmt also needs support for this feature. The tracking issue is here. I'm planning to tackle that eventually but I'm not going to lick the cookie just yet.

[nikomatsakis]

I opened #38830 to specifically track adding docs.