Skip to content

Warn unused trait imports - #30021

Closed
sanxiyn wants to merge 4 commits into
rust-lang:masterfrom
sanxiyn:unused-trait-import
Closed

Warn unused trait imports#30021
sanxiyn wants to merge 4 commits into
rust-lang:masterfrom
sanxiyn:unused-trait-import

Conversation

@sanxiyn

@sanxiyn sanxiyn commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

Fix #25730.

@rust-highfive

rust-highfive commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@sanxiyn
sanxiyn force-pushed the unused-trait-import branch 2 times, most recently from 6c87a38 to e63ee8b Compare November 24, 2015 15:26
@bors

bors commented Nov 26, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #30043) made this pull request unmergeable. Please resolve the merge conflicts.

@sanxiyn
sanxiyn force-pushed the unused-trait-import branch from e63ee8b to 02cda6b Compare November 27, 2015 05:35
@bors

bors commented Nov 27, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #30064) made this pull request unmergeable. Please resolve the merge conflicts.

@sanxiyn
sanxiyn force-pushed the unused-trait-import branch from 02cda6b to ec1f6ca Compare December 1, 2015 07:58
@bors

bors commented Dec 3, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #29999) made this pull request unmergeable. Please resolve the merge conflicts.

@sanxiyn
sanxiyn force-pushed the unused-trait-import branch from ec1f6ca to 357cb9c Compare December 7, 2015 12:03
@sanxiyn sanxiyn mentioned this pull request Dec 8, 2015
Closed
@bors

bors commented Dec 9, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #30145) made this pull request unmergeable. Please resolve the merge conflicts.

@arielb1

arielb1 commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

Sorry for the delay.

Why is the unused import lint inside rustc_typeck rather than rustc_lint? Also, I would prefer to have a single hashset of used trait imports, rather than 2.

@sanxiyn

sanxiyn commented Dec 10, 2015

Copy link
Copy Markdown
Contributor Author

unused_imports is one of HardwiredLints, so it can't be inside rustc_lint.

Two sets are basically a set of trait imports and a set of used trait imports, not two sets of used trait imports. maybe_unused_trait_imports is a set of trait imports (minus those used by name) saved for use post-resolution.

@sanxiyn
sanxiyn force-pushed the unused-trait-import branch from 357cb9c to d0881e1 Compare December 11, 2015 11:47
@bors

bors commented Dec 17, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #30325) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

alexcrichton commented Jan 27, 2016

Copy link
Copy Markdown
Member

(ping)

Does this just need a rebase? A re-review?

(just trying to clear out the queue)

@alexcrichton

alexcrichton commented Mar 8, 2016

Copy link
Copy Markdown
Member

Closing due to inactivity, but feel free to resubmit with a rebase!

This was referenced Apr 12, 2016
Merged
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 22, 2016
@Manishearth
Rollup merge of rust-lang#33091 - sanxiyn:unused-trait-import-3, r=nrc
9cdfc10 
Warn unused trait imports, rebased

Rebase of rust-lang#30021.

Fix rust-lang#25730.
bors added a commit that referenced this pull request May 4, 2016
@bors
Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
a31aa6c 
Warn unused trait imports, rebased

Rebase of #30021.

Fix #25730.
bors added a commit that referenced this pull request May 8, 2016
@bors
Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
8e414e0 
Warn unused trait imports, rebased

Rebase of #30021.

Fix #25730.
@sanxiyn
sanxiyn deleted the unused-trait-import branch May 8, 2016 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1 arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sanxiyn @rust-highfive @bors @arielb1 @alexcrichton