Add make clean support to rustbuild - #31591
Merged
Merged
Conversation
Also add a `clean` target for the makefiles to blow away everything related to the build. Note that this specifically does not tamper with: * the LLVM build directory * the directory of the bootstrap system * the cached downloads of cargo/rustc
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
48 tasks
Contributor
|
r=me with nits |
The build bots already use job objects, and they don't support nested job objects, and we shouldn't entirely bail out in this case anyway!
alexcrichton
force-pushed
the
make-clean-with-rustbuild
branch
from
February 12, 2016 18:40
cd8a86c to
07638b9
Compare
Member
Author
bors
added a commit
that referenced
this pull request
Feb 13, 2016
At the same time also touch up the job management on Windows to be a little more resilient to failure.
Collaborator
|
⌛ Testing commit 07638b9 with merge bc91927... |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the same time also touch up the job management on Windows to be a little more resilient to failure.