Make configure not require ocamlc - #349
Closed
rillian wants to merge 15 commits into
Closed
Conversation
Since moving to a downloadable snapshot for stage0, it's been possible to complete the build without compiling code written in ocaml. However, the configure script still required it to be present. This commit changes detection failure to a non-fatal condition, allowing the build to complete on systems without an ocaml compiler. An info message is also made conditional.
…in session, and use it.
There was some confusion on whether the destructors took their argument by pointer or direct value. They now take it directly, just like other methods. You no longer get a segfault when a constructor actually does something with its self value.
Since moving to a downloadable snapshot for stage0, it's been possible to complete the build without compiling code written in ocaml. However, the configure script still required it to be present. This commit changes detection failure to a non-fatal condition, allowing the build to complete on systems without an ocaml compiler. An info message is also made conditional.
This applies c11675 by Julian Seward from valgrind trunk (svn://svn.valgrind.org/valgrind/trunk) to rustrt's included copies of memcheck.h and valgrind.h, effectively backporting the fix from the unreleased 3.6.2. The commit simply applies the gcc 'unused' attribute to the relevant declarations. This change allows compilation of the runtime code under gcc 4.6 with -Werror, as the makefile currently requests.
Contributor
|
Cherry-picked. Thanks. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Add memcpy and memmove
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
This way if the feature is statically detected then it'll be expanded to `true` Closes rust-lang#349
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Oct 26, 2020
antoyo
added a commit
to antoyo/rust
that referenced
this pull request
Oct 9, 2023
…ations Fix/128 bit ints operations
carolynzech
pushed a commit
to carolynzech/rust
that referenced
this pull request
May 7, 2025
This is an automated PR to update Kani metrics. The metrics have been updated by running `./scripts/run-kani.sh --run metrics`. Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
noscripter
pushed a commit
to noscripter/rust
that referenced
this pull request
Sep 8, 2025
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
349: Bump serde from 1.0.82 to 1.0.83 r=matklad a=dependabot[bot] Bumps [serde](https://github.com/serde-rs/serde) from 1.0.82 to 1.0.83. <details> <summary>Release notes</summary> *Sourced from [serde's releases](https://github.com/serde-rs/serde/releases).* > ## v1.0.83 > - Support a `rename_all` specification that applies only to the Serialize impl or only to the Deserialize impl ([rust-lang#1447](https://github-redirect.dependabot.com/serde-rs/serde/issues/1447), thanks [**vincascm**](https://github.com/vincascm)) > > ```rust > #[derive(Serialize, Deserialize)] > #[serde(rename_all( > serialize = "camelCase", > deserialize = "SCREAMING_SNAKE_CASE", > ))] > struct S { /* ... */ } > ``` > > - Allow serializing struct name inside of structs with named fields ([rust-lang#1448](https://github-redirect.dependabot.com/serde-rs/serde/issues/1448), thanks [**motu42**](https://github.com/motu42)) > > ```rust > #[derive(Serialize)] > #[serde(tag = "type")] > struct S { /* ... */ } // serializes as {"type":"S",...} > ``` </details> <details> <summary>Commits</summary> - [`b1b9702`](serde-rs/serde@b1b9702) Release 1.0.83 - [`32728d2`](serde-rs/serde@32728d2) Format with rustfmt 2018-12-10 - [`807a097`](serde-rs/serde@807a097) Fix spelling in ui test name - [`794ee15`](serde-rs/serde@794ee15) Merge pull request [rust-lang#1448](https://github-redirect.dependabot.com/serde-rs/serde/issues/1448) from motu42/master - [`2359417`](serde-rs/serde@2359417) Added ui tests, Limited serde(tag = "...") to structs with named field - [`7950f3c`](serde-rs/serde@7950f3c) Format with rustfmt 2018-12-10 - [`b87f8f3`](serde-rs/serde@b87f8f3) Merge pull request 1447 from vincascm/master - [`9e53405`](serde-rs/serde@9e53405) Fix for rustc 1.15.0 - [`c6c1d8f`](serde-rs/serde@c6c1d8f) Work around deprecation of str::trim_left_matches - [`8aa5c2b`](serde-rs/serde@8aa5c2b) Removed deprected ui/enum-representation/internally-tagged-struct test - Additional commits viewable in [compare view](serde-rs/serde@v1.0.82...v1.0.83) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=serde&package-manager=cargo&previous-version=1.0.82&new-version=1.0.83) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot[bot] <support@dependabot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since moving to a downloadable snapshot for stage0, it's been
possible to complete the build without compiling code written
in ocaml. However, the configure script still required it to
be present.
This commit changes detection failure to a non-fatal condition,
allowing the build to complete on systems without an ocaml
compiler.
An info message is also made conditional.