The request-scoped WebClient doesn't use the provided logger

[dirleyrls-kake]

Bolt is creating a WebClient instance for each request its handling here:

bolt-python/slack_bolt/app/app.py

Line 1376 in 3ad0788

client_per_request: WebClient = WebClient(

It does not pass the logger param.

This means that all requests that are logged by that client won't use the logger provided to the App.

[WilliamBergamin]

Hi @dirleyrls-kake thanks for bringing this up 💯

The line above the initialization of client_per_request we assign the Bolt app logger to the context of the request, from my perspective it makes sense to have a logger for Bolt and another for the WebClient since they are separate libraries 🤔 (slack-bolt, slack-sdk), what would be your expected behavior and why?

[dirleyrls-kake]

@WilliamBergamin , thanks for the reply.

You are right they are separate libraries, but this particular WebClient is an internal resource created & owned by Slack Bolt. If I configure a custom logger while setting up Slack Bolt, I expect this custom logger to be propagated to every resource that Slack Bolt creates internally.

In my particular use-case, I want to customize all Slack-related loggers to include a prefix ([slack]). This expectation extends to the logger used by the WebClient too, since its an internal resource.

I searched the docs for a way to achieve this but found none. I noticed in some places Bolt tries to propagate the logger, eg.:

bolt-python/slack_bolt/oauth/oauth_flow.py

Line 76 in 98f0b46

self._client = create_web_client(logger=self.logger)

and

bolt-python/slack_bolt/app/app.py

Line 239 in 98f0b46

self._client = create_web_client(

.

Currently I had to overload some private method to customize this logger:

class LoggerRespectingBoltApp(App):
    def _init_context(self, req: BoltRequest):
        super()._init_context(req)
        req.context["client"]._logger = logger

If you don't want to propagate the logger by default could you at least provide a public API and some documentation about how to do it?

[WilliamBergamin]

I looked more into this and and I think it is a bug 🤔

Looking back it seems like the intention of #246 was to make this possible and I believe it was working for a while, until #714 which creates a copy of the client for each request and did not carry over the logger set up in the app client instance

We will need to make changes to the underlying sdk in order to expose the client logger

[WilliamBergamin]

There is one more bolt PR that must land before we can resolve this issue, the changes rely on a new version of the sdk, an sdk release is planned for early next week 🚀