Appended form config fields use inline view

[andjsch]

Bug description

It appears that the appended form config fields use the inline option as well, just as the mailer config did #13520.

I could fix it somewhat by adding 'full_width_setting' => true. But I had expected it to be behave like in a normal blueprint, but I guess that can be discussed. However, the full_width_setting should definitely be true by default.

How to reproduce

Form::appendConfigFields('*', __('Custom form sender text'), [
    'content_sender' => [
        'full_width_setting' => true,
        'type' => 'group',
        'display' => '',
        'fullscreen' => false,
        'border' => false,
        'fields' => [
            ['import' => 'form_email_config']
        ]
    ],
]);

Logs

Environment

v6-beta-6

Installation

Fresh statamic/statamic site via CLI

Additional details

No response

[leon-fablr]

I'm currently testing moving one of our statamic 5 sites onto statamic 6 and encountering this as a problem as well.

We have nested groups in the fields/blueprint we supply to appendConfigFields - resulting in it completely breaking the layout on a 1080p display.

Statamic 6

Statamic 5

[duncanmcclean]

Like a lot of other settings pages, the "Configure Form" page uses the asConfig prop which displays fields a little differently to the traditional content-based publish forms.

If you want fields to be full width in this context, you should add 'full_width_setting' => true. It's not the default because there are times, like this, where you don't want fields to be full width. It depends on the setting.

[andjsch]

This doesn't fully solve the issue. If you look at my second screenshot, the asConfig prop seems to be passed into the imported fieldset as well. If I remember correctly, it can't be overwritten in the fieldset with false. Meaning there's no way to display a field in full width, without the label taking half of the width.

[leon-fablr]

Above matches my experience. I'm noticing no change in output when changing this in this context - regardless of whether this full_width_setting exists or not or whether its true or false. E.g.

Form::appendConfigFields('*', 'Form configuration', [
    'data' => [
        'type' => 'group',
        'display' => 'Settings',
        'border' => true,
        'fullscreen' => true,
        'full_width_setting' => true,
        'fields' => [ ... ],
    ]
]);

The same is true of adding full_width_setting => true and/or false on child groups. Doing a find on it I can see that there is a reference to full_width_setting in the frontend code, at least.

[daun]

The issue seems to be with nesting. The asConfig flag is being passed down with each level, leading to the two-column layout being applied even in nested replicator, grid or group fields. The solution is probably to only apply asConfig to the top-level fields in each blueprint.

[daun]

To illustrate with an example: setting asConfig renders the main fields just fine, but it applies the two-column layout to nested replicators, which on most screen sizes just doesn't work.

[daun]

Should be solved by #14855.