[5.x] Prevent some folders from listing in template fieldtype - #10031
Merged
Conversation
duncanmcclean
changed the title
jasonvarga
approved these changes
May 24, 2024
jasonvarga
left a comment
jasonvarga
left a comment
Member
There was a problem hiding this comment.
I noticed some issues even after your changes with unexpected items being shown, like incorrect paths etc.
I've added tests, corrected the issues, and cleaned things up a bit.
Thanks!
Contributor
Author
|
Thank you! It appears that more testing is required. I will conduct additional tests to ensure everything is in order before pushing the changes. |
Member
|
It's okay, we got it. Thanks! |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When incorporating views as a git submodule and setting up a node project, you'll observe that the 'template' field type lists all folders, including 'node_modules,' which is an undesired behavior.