[6.x] Added autocomplete attribute to confirm-password screen - #15101
Merged
Conversation
mytchallb
changed the title
Contributor
Author
|
Also noted in an Issue, that main Statamic admin login screen has this same autocomplete attribute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The confirm-password screen doesn't have an autocomplete attribute on the password input, so password managers, eg, 1Password may not autofill it.
I added "current-password" as an attribute which is mentioned on W3 docs (Tested the attribute in CodePen and 1PW picked up on the right attribute)
Closes #15102