[6.x] Fix Antlers identifiers erroring before the parser has been resolved - #15221
Merged
jasonvarga merged 1 commit intoAug 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an entry can fail with
Call to a member function isTag() on nullwhen an addon callsAntlers::identifiers()during a control panel request (SEO Pro does this from its previews fieldtype).NodeTypeAnalyzer::$environmentDetailsis only assigned as a side effect of the container resolvingEnvironmentDetails, which happens when something builds a parser.Antlers::identifiers()runs the document parser directly, so if nothing else in the request has resolved a parser yet, the analyzer is left with a null. Whether that had happened by then was incidental, which is why #14988 (site config values no longer go through Antlers unless they actually contain Antlers) started surfacing it.The analyzer now resolves the environment details itself the first time it needs them.
Fixes #15220