Better proposal reference check - #4999
Merged
Merged
Conversation
For each missing proposal, check if it is deleting an index which is already deleted by an included proposal. If so, do not throw a missing reference error.
pcapriotti
force-pushed
the
mls-duplicate-proposals
branch
from
February 3, 2026 15:18
2f40fae to
5e051b1
Compare
zebot
added
the
ok-to-test
blackheaven
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When duplicated proposals are present (e.g. because something went wrong when deleting a client or a user, and the operation was retried), new commits were rejected because they cannot contain all the pending proposal refs.
This PR fixes the issue by making the proposal ref check ignore missing proposals that delete clients which are already deleted by other proposals in the commit.
https://wearezeta.atlassian.net/browse/WPB-23249
Checklist
changelog.d