[WPB-22549] fix conv join events - #5052
Merged
Merged
Conversation
fisx
commented
Feb 20, 2026
fisx
force-pushed
the
WPB-22549-fix-conv-join-events
branch
from
February 23, 2026 07:40
dea1f18 to
b3d4baa
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in conversation join events by filtering out deleted users from the internal user lookup API endpoint. The issue was that deleted users could be returned during user lookups, causing event delivery failures when apps or users tried to add members to conversations.
Changes:
- Modified
GET /i/usersendpoint to filter out users withDeletedstatus to prevent race conditions - Removed test workaround that was skipping assertions for app-to-user conversation events
- Corrected grammar in comment from "Empty list is" to "Empty lists are"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/brig/src/Brig/API/Internal.hs | Adds filtering to exclude deleted users from listActivatedAccountsH and fixes comment grammar |
| integration/test/Test/Conversation.hs | Removes conditional workaround and increases key package uploads to ensure sufficient packages for all test scenarios |
| changelog.d/5-internal/WPB-22549-reduce-get-i-users-noise | Documents the internal API change and its purpose |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blackheaven
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d