Skip to content

[WPB-22549] fix conv join events - #5052

Merged
fisx merged 4 commits into
developfrom
WPB-22549-fix-conv-join-events
Feb 23, 2026
Merged

[WPB-22549] fix conv join events#5052
fisx merged 4 commits into
developfrom
WPB-22549-fix-conv-join-events

Conversation

@fisx

@fisx fisx commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

Comment thread integration/test/Test/Conversation.hs Outdated
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 20, 2026
@fisx
fisx force-pushed the WPB-22549-fix-conv-join-events branch from dea1f18 to b3d4baa Compare February 23, 2026 07:40
@fisx
fisx marked this pull request as ready for review February 23, 2026 07:49
@fisx
fisx requested review from a team as code owners February 23, 2026 07:49
@fisx
fisx requested a review from Copilot February 23, 2026 07:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a race condition in conversation join events by filtering out deleted users from the internal user lookup API endpoint. The issue was that deleted users could be returned during user lookups, causing event delivery failures when apps or users tried to add members to conversations.

Changes:

  • Modified GET /i/users endpoint to filter out users with Deleted status to prevent race conditions
  • Removed test workaround that was skipping assertions for app-to-user conversation events
  • Corrected grammar in comment from "Empty list is" to "Empty lists are"

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
services/brig/src/Brig/API/Internal.hs Adds filtering to exclude deleted users from listActivatedAccountsH and fixes comment grammar
integration/test/Test/Conversation.hs Removes conditional workaround and increases key package uploads to ensure sufficient packages for all test scenarios
changelog.d/5-internal/WPB-22549-reduce-get-i-users-noise Documents the internal API change and its purpose

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fisx
fisx merged commit 64b7786 into develop Feb 23, 2026
13 of 14 checks passed
@fisx
fisx deleted the WPB-22549-fix-conv-join-events branch February 23, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants