Skip to content

[WPB-21287] put app metadata - #5053

Merged
fisx merged 5 commits into
developfrom
WPB-21287-put-app-metadata
Feb 24, 2026
Merged

[WPB-21287] put app metadata#5053
fisx merged 5 commits into
developfrom
WPB-21287-put-app-metadata

Conversation

@fisx

@fisx fisx commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx
fisx force-pushed the WPB-21287-put-app-metadata branch from 846cafd to 85bbf71 Compare February 23, 2026 13:20
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 23, 2026
@fisx
fisx force-pushed the WPB-21287-put-app-metadata branch 3 times, most recently from 55dc217 to 82efe30 Compare February 23, 2026 17:17
@fisx
fisx force-pushed the WPB-21287-put-app-metadata branch from 82efe30 to 5c9790e Compare February 23, 2026 17:39
@fisx
fisx marked this pull request as ready for review February 23, 2026 17:39
@fisx
fisx requested review from a team as code owners February 23, 2026 17:39
@fisx
fisx requested a review from Copilot February 23, 2026 17:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new public Brig endpoint to update an existing team app’s “metadata” (app-facing profile fields + app store category/description), wiring it through AppSubsystem and AppStore down to Postgres, and covering it with an integration test.

Changes:

  • Introduce PUT /teams/:tid/apps/:uid and a new request payload type PutApp.
  • Add UpdateApp operations to AppSubsystem and AppStore, with a Postgres implementation.
  • Add an integration test exercising the new endpoint and verifying updated fields via GET /teams/:tid/apps/:uid.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/brig/src/Brig/API/Public.hs Wires the new put-app handler into Brig’s public API server.
libs/wire-api/src/Wire/API/Routes/Public/Brig.hs Exposes the new put-app route in the public API surface.
libs/wire-api/src/Wire/API/App.hs Adds PutApp request type + schema for partial app updates.
libs/wire-subsystems/src/Wire/AppSubsystem.hs Adds UpdateApp effect to the App subsystem.
libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs Implements updateAppImpl by updating app store + user store fields.
libs/wire-subsystems/src/Wire/AppStore.hs Introduces StoredAppUpdate and AppStoreError, and adds UpdateApp to the store effect.
libs/wire-subsystems/src/Wire/AppStore/Postgres.hs Implements UpdateApp against the apps table.
libs/wire-subsystems/test/unit/Wire/MockInterpreters/AppStore.hs Extends the in-memory AppStore interpreter with an UpdateApp case (currently stubbed).
integration/test/API/Brig.hs Adds a test helper to call the new PUT endpoint.
integration/test/Test/Apps.hs Adds an integration test validating app metadata updates.
changelog.d/1-api-changes/WPB-21287-put-app-metadata Documents the new public API endpoint.
Comments suppressed due to low confidence (1)

libs/wire-api/src/Wire/API/Routes/Public/Brig.hs:2143

  • The route summary says "Update metadata of an existing app", but this endpoint updates only a subset of app fields (name/assets/accent/category/description) and does not update the metadata/picture fields returned by GetApp. Please clarify the summary/description to match the actual updatable fields to avoid misleading API consumers.
           ( Summary "Update metadata of an existing app"
               :> From 'V15

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libs/wire-subsystems/test/unit/Wire/MockInterpreters/AppStore.hs
Comment thread libs/wire-subsystems/src/Wire/AppStore/Postgres.hs Outdated
Comment thread integration/test/Test/Apps.hs
@fisx
fisx requested a review from blackheaven February 24, 2026 08:25
@fisx
fisx merged commit 7c59895 into develop Feb 24, 2026
8 of 10 checks passed
@fisx
fisx deleted the WPB-21287-put-app-metadata branch February 24, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants