[WPB-21287] put app metadata - #5053
Merged
Merged
Conversation
fisx
force-pushed
the
WPB-21287-put-app-metadata
branch
from
February 23, 2026 13:20
846cafd to
85bbf71
Compare
fisx
force-pushed
the
WPB-21287-put-app-metadata
branch
3 times, most recently
from
February 23, 2026 17:17
55dc217 to
82efe30
Compare
fisx
force-pushed
the
WPB-21287-put-app-metadata
branch
from
February 23, 2026 17:39
82efe30 to
5c9790e
Compare
fisx
marked this pull request as ready for review
February 23, 2026 17:39
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new public Brig endpoint to update an existing team app’s “metadata” (app-facing profile fields + app store category/description), wiring it through AppSubsystem and AppStore down to Postgres, and covering it with an integration test.
Changes:
- Introduce
PUT /teams/:tid/apps/:uidand a new request payload typePutApp. - Add
UpdateAppoperations toAppSubsystemandAppStore, with a Postgres implementation. - Add an integration test exercising the new endpoint and verifying updated fields via
GET /teams/:tid/apps/:uid.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/brig/src/Brig/API/Public.hs | Wires the new put-app handler into Brig’s public API server. |
| libs/wire-api/src/Wire/API/Routes/Public/Brig.hs | Exposes the new put-app route in the public API surface. |
| libs/wire-api/src/Wire/API/App.hs | Adds PutApp request type + schema for partial app updates. |
| libs/wire-subsystems/src/Wire/AppSubsystem.hs | Adds UpdateApp effect to the App subsystem. |
| libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs | Implements updateAppImpl by updating app store + user store fields. |
| libs/wire-subsystems/src/Wire/AppStore.hs | Introduces StoredAppUpdate and AppStoreError, and adds UpdateApp to the store effect. |
| libs/wire-subsystems/src/Wire/AppStore/Postgres.hs | Implements UpdateApp against the apps table. |
| libs/wire-subsystems/test/unit/Wire/MockInterpreters/AppStore.hs | Extends the in-memory AppStore interpreter with an UpdateApp case (currently stubbed). |
| integration/test/API/Brig.hs | Adds a test helper to call the new PUT endpoint. |
| integration/test/Test/Apps.hs | Adds an integration test validating app metadata updates. |
| changelog.d/1-api-changes/WPB-21287-put-app-metadata | Documents the new public API endpoint. |
Comments suppressed due to low confidence (1)
libs/wire-api/src/Wire/API/Routes/Public/Brig.hs:2143
- The route summary says "Update metadata of an existing app", but this endpoint updates only a subset of app fields (name/assets/accent/category/description) and does not update the
metadata/picturefields returned byGetApp. Please clarify the summary/description to match the actual updatable fields to avoid misleading API consumers.
( Summary "Update metadata of an existing app"
:> From 'V15
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blackheaven
requested changes
Feb 23, 2026
blackheaven
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d