Skip to content

WPB-21964: Add Wire Meetings update - #5065

Merged
blackheaven merged 2 commits into
developfrom
gdifolco/WPB-21964-wire-meetings-update
Feb 26, 2026
Merged

WPB-21964: Add Wire Meetings update#5065
blackheaven merged 2 commits into
developfrom
gdifolco/WPB-21964-wire-meetings-update

Conversation

@blackheaven

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-21964

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven
blackheaven requested review from a team as code owners February 26, 2026 07:24
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 26, 2026

@fisx fisx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! as always, please consider all my comments questions of the clueless, not orders. :)

Comment thread libs/wire-subsystems/test/unit/Wire/MeetingsSubsystem/InterpreterSpec.hs Outdated
Comment thread integration/test/Test/Meetings.hs
"end_date" .= endTime
]

putMeeting otherUser domain meetingId update >>= assertStatus 404

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 403?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's another user, in another team, they should not be aware of this meeting.

Comment thread libs/wire-api/src/Wire/API/Meeting.hs
@blackheaven
blackheaven merged commit ad0b9a3 into develop Feb 26, 2026
10 checks passed
@blackheaven
blackheaven deleted the gdifolco/WPB-21964-wire-meetings-update branch February 26, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants