Skip to content

[WPB-23644] add app data to get /list-users - #5070

Merged
fisx merged 24 commits into
developfrom
WPB-23644-add-app-data-to-get-list-users
Mar 16, 2026
Merged

[WPB-23644] add app data to get /list-users#5070
fisx merged 24 commits into
developfrom
WPB-23644-add-app-data-to-get-list-users

Conversation

@fisx

@fisx fisx commented Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 27, 2026
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch from 6f3c91e to b5afbd9 Compare March 3, 2026 16:07
@fisx
fisx changed the base branch from develop to WPB-23644-fix-subsystems-dep-graph March 3, 2026 16:08
@fisx
fisx force-pushed the WPB-23644-fix-subsystems-dep-graph branch from e881280 to de3e000 Compare March 4, 2026 06:50
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch from b5afbd9 to 4de6c1f Compare March 4, 2026 21:18
@fisx
fisx force-pushed the WPB-23644-fix-subsystems-dep-graph branch from f560ec9 to 31b6e3a Compare March 9, 2026 09:36
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch 4 times, most recently from 05a1630 to 09f27e8 Compare March 10, 2026 14:49
@blackheaven
blackheaven force-pushed the WPB-23644-add-app-data-to-get-list-users branch from 09f27e8 to c0ccf88 Compare March 10, 2026 14:56
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch 2 times, most recently from 8187777 to 7eeb24a Compare March 10, 2026 16:26
@fisx
fisx force-pushed the WPB-23644-fix-subsystems-dep-graph branch from f02ae2f to eea2326 Compare March 11, 2026 08:41
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch 2 times, most recently from 1646f38 to 8df2159 Compare March 11, 2026 11:10
fisx
fisx commented Mar 11, 2026
View reviewed changes
Comment thread libs/wire-api/src/Wire/API/User.hs
<*> listUsersByIdFailed .= maybe_ (optField "failed" $ nonEmptyArray schema)

--------------------------------------------------------------------------------
-- Apps (can't easily go into its own module because cyclical deps)

@fisx fisx Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hasn't changed in the process of moving here from Wire.API.App, promise! :)

@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch from f4090b5 to c8bd8be Compare March 12, 2026 10:58
blackheaven
blackheaven requested changes Mar 12, 2026
View reviewed changes
Comment thread libs/wire-api/src/Wire/API/User/Profile.hs
Comment thread libs/wire-subsystems/src/Wire/UserSubsystem.hs Outdated
Comment thread services/brig/src/Brig/API/Public.hs Outdated
:<|> Named @"get-apps" getApps
:<|> Named @"put-app" putApp
:<|> Named @"refresh-app-cookie" refreshAppCookie
:<|> Named @"refresh-app-cookie" refreshAppCookie -- TODO: does this invalidate the old cookies?

@blackheaven blackheaven Mar 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:<|> Named @"refresh-app-cookie" refreshAppCookie -- TODO: does this invalidate the old cookies?
:<|> Named @"refresh-app-cookie" refreshAppCookie -- FUTUREWORK: does this invalidate the old cookies?

@fisx fisx Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

47fe429

@fisx
fisx requested a review from blackheaven March 12, 2026 13:24
@fisx
fisx force-pushed the WPB-23644-fix-subsystems-dep-graph branch from fda21d2 to b6654a3 Compare March 12, 2026 13:25
Base automatically changed from WPB-23644-fix-subsystems-dep-graph to develop March 12, 2026 14:18
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch from 47fe429 to 15d88af Compare March 12, 2026 14:20
@fisx
fisx marked this pull request as ready for review March 12, 2026 14:45
@fisx
fisx requested review from a team as code owners March 12, 2026 14:45
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch from 61bab58 to 0be8b3a Compare March 12, 2026 20:44
fisx and others added 22 commits March 14, 2026 14:57
@fisx
Move Wire.API.App into Wire.API.User to resolve cyclical deps.
a630839 
(see upcoming commit.)
@fisx
Mark Pict schema deprecated in swagger (not only in source code).
67a7e67
@fisx
Re-format wire-api golden tests.
6b156de 
People have added fields manually in the past, this will show
irrelevant syntactic differences when re-creating the affected
schemas.  Semantics does not change in this commit.
@fisx
Eliminate Embed IO dependency in AppSubsystem.
7dfa0b2
@fisx
Make get-app,s end-points return user profiles not of only app info.
6d169d5
@fisx
Add profileApp :: GetApp to UserProfile (but don't fill it yet).
b3e6ac5
@fisx
Actually add GetApp to UserProfile in UserSubsystem.
d5244e5 
(except for recursion, so it's not working yet, but it's clear from
the code how it should work.)
@fisx
Mutual recursion between three subsystems (not two).
fe1db47 
thanks paolo!  :)
@fisx
Mutual recursion part II (cleanup).
3f38e3f
@fisx
Mutual recursion part IIb (some more cleanup).
82444f2
@fisx
Mutual recursion part III (brig).
1c5de1a
@fisx
Fix Changelog; obey hlint.
f07f76d
@fisx
Fix Changelog.
07da1dd
@fisx
Nit-pick.
8d3ce9e
@fisx
Turn TODOs into jira tickets.
13abbf4 
https://wearezeta.atlassian.net/browse/WPB-23990
https://wearezeta.atlassian.net/browse/WPB-23995
@fisx
Make missing app info explicit in UserProfile constructor.
2947b22 
(Application logic in UserSubsystem is still responsible for filling
the app field after the user profile has been constructed.  But this
way it's more explicit.)
@fisx
Postpone last remaining TODOs.
32af5c6
@fisx @blackheaven
use note not maybe/throw
c9b177a 
Co-authored-by: Gautier DI FOLCO <gautier.difolco@wire.com>
@fisx
Remove another stale TODO.
cb9ff75 
https://wearezeta.atlassian.net/browse/WPB-24033
@fisx
Fixup: integration tests.
a7fdaaa
@fisx
Postpone dealing with app visibility.
077dc6a 
See https://wearezeta.atlassian.net/browse/WPB-23995, https://wearezeta.atlassian.net/browse/WPB-23840
@fisx
Makefile: adjust "make cqlsh" to new cassandra version.
9ff8bc7
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch 2 times, most recently from 110a3ec to fe08422 Compare March 14, 2026 14:31
@fisx
Fix: don't try to load apps entry for deleted profiles.
f692b24 
Also don't return deleted profiles from "get-apps".
@fisx
fisx force-pushed the WPB-23644-add-app-data-to-get-list-users branch from fe08422 to f692b24 Compare March 16, 2026 08:54
@fisx
fisx merged commit f1b7f17 into develop Mar 16, 2026
10 checks passed
@fisx
fisx deleted the WPB-23644-add-app-data-to-get-list-users branch March 16, 2026 09:53
@zebot zebot mentioned this pull request Mar 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blackheaven blackheaven blackheaven approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fisx @blackheaven @zebot