WPB-23896: Handle SonarQube last blocker and high/medium warnings - #5097
Merged
blackheaven merged 4 commits intoMar 9, 2026
Conversation
zebot
added
the
ok-to-test
supersven
reviewed
Mar 9, 2026
supersven
requested changes
Mar 9, 2026
Contributor
|
IMHO this deserves a changelog entry as we don't have tests for our scripts and - though I don't expect it - something might be broken. Then, I hint like "We touched the scripts" could be helpful to script users. |
Contributor
Author
|
Thanks for the review, I have added a changelog |
supersven
reviewed
Mar 9, 2026
supersven
approved these changes
Mar 9, 2026
supersven
left a comment
supersven
left a comment
Contributor
There was a problem hiding this comment.
Given the CI goes green, I'd say: LGTM 👍
Thanks a lot for taking the time to improve our helper scripts ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23896
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d