Skip to content

WPB-23789: Break dependencies to Opts/Env - #5110

Merged
blackheaven merged 3 commits into
developfrom
gdifolco/WPB-23789-break-dep-env-opts
Mar 11, 2026
Merged

WPB-23789: Break dependencies to Opts/Env#5110
blackheaven merged 3 commits into
developfrom
gdifolco/WPB-23789-break-dep-env-opts

Conversation

@blackheaven

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-23789

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven
blackheaven requested review from a team as code owners March 10, 2026 18:31
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 10, 2026

@supersven supersven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks a lot for taking the time to improve our code base. ❤️

@supersven

Copy link
Copy Markdown
Contributor

⚠️ Looks like the concourse didn't start, yet! ⚠️

@blackheaven

Copy link
Copy Markdown
Contributor Author

Someone put a rate limiter on Concourse! (my other PRs have the issue)

@supersven

Copy link
Copy Markdown
Contributor

Someone put a rate limiter on Concourse! (my other PRs have the issue)

There was an abandoned pin... 😬 I've removed it. Should start to run now.

@blackheaven

Copy link
Copy Markdown
Contributor Author

I was certainly mine... instant karma.

Sorry for that and thank you!

Base automatically changed from gdifolco/WPB-23789-drop-galley-api-push to develop March 10, 2026 21:36
@blackheaven
blackheaven force-pushed the gdifolco/WPB-23789-break-dep-env-opts branch from 7328460 to d94648e Compare March 10, 2026 21:37
@blackheaven
blackheaven merged commit a27fe1b into develop Mar 11, 2026
10 checks passed
@blackheaven
blackheaven deleted the gdifolco/WPB-23789-break-dep-env-opts branch March 11, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants