Skip to content

[WPB-23764] app events - #5139

Merged
fisx merged 5 commits into
developfrom
WPB-23764-app-events
Mar 24, 2026
Merged

[WPB-23764] app events#5139
fisx merged 5 commits into
developfrom
WPB-23764-app-events

Conversation

@fisx

@fisx fisx commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx
fisx force-pushed the WPB-23764-app-events branch from 8897df9 to b9b6c24 Compare March 19, 2026 16:39
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 19, 2026
@fisx
fisx force-pushed the WPB-23764-app-events branch from b9b6c24 to f8786b3 Compare March 20, 2026 09:05
@fisx

fisx commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

the status quo the status quo is a bit odd:

  • create app event gets sent to owners, admins, and to the team queue.
  • delete app event gets sent to all team members directly (not via team queue).
  • update app event only gets sent to owners, admins, not the team queue.

is this right? doesn't look very coherent to me.

no, wait, the test is flaky now. i'll double-check, but any opinions on what should be the behavior?

@fisx
fisx force-pushed the WPB-23764-app-events branch 2 times, most recently from a0f8ea8 to d8c4c48 Compare March 23, 2026 11:09
@fisx
fisx marked this pull request as ready for review March 23, 2026 11:12
@fisx
fisx requested review from a team as code owners March 23, 2026 11:12
@fisx
fisx requested a review from Copilot March 23, 2026 11:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates how “app user” lifecycle events are emitted/validated by aligning app creation with existing team membership semantics (using team.member-join instead of a dedicated team.app-create event), and adjusts integration tests accordingly.

Changes:

  • Emit EdMemberJoin when creating an app user (replacing the prior app-create event usage).
  • Remove EdAppCreate from the team event data model and its JSON parsing/generation.
  • Expand integration tests to assert websocket + team-notification behavior for app users, and adjust list-users expectations.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs Switches app creation team event from EdAppCreate to EdMemberJoin.
libs/wire-api/src/Wire/API/Event/Team.hs Removes EdAppCreate from EventData and related JSON parsing/generation paths.
integration/test/Test/Apps.hs Adds websocket/team-notification assertions for app create/delete; refines list-users expected shape.
changelog.d/3-bug-fixes/WPB-23764-app-events Documents the change in event expectations and integration coverage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libs/wire-api/src/Wire/API/Event/Team.hs
Comment thread libs/wire-api/src/Wire/API/Event/Team.hs
Comment thread changelog.d/3-bug-fixes/WPB-23764-app-events
@fisx
fisx marked this pull request as draft March 23, 2026 12:09
@fisx
fisx force-pushed the WPB-23764-app-events branch from 79f1c6f to 686879c Compare March 23, 2026 12:27
@fisx
fisx marked this pull request as ready for review March 23, 2026 12:28
@fisx
fisx merged commit a2333ac into develop Mar 24, 2026
10 checks passed
@fisx
fisx deleted the WPB-23764-app-events branch March 24, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants