[WPB-23764] app events - #5139
Merged
Merged
Conversation
fisx
force-pushed
the
WPB-23764-app-events
branch
from
March 19, 2026 16:39
8897df9 to
b9b6c24
Compare
fisx
force-pushed
the
WPB-23764-app-events
branch
from
March 20, 2026 09:05
b9b6c24 to
f8786b3
Compare
Contributor
Author
|
is this right? doesn't look very coherent to me. no, wait, the test is flaky now. i'll double-check, but any opinions on what should be the behavior? |
fisx
force-pushed
the
WPB-23764-app-events
branch
2 times, most recently
from
March 23, 2026 11:09
a0f8ea8 to
d8c4c48
Compare
fisx
marked this pull request as ready for review
March 23, 2026 11:12
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates how “app user” lifecycle events are emitted/validated by aligning app creation with existing team membership semantics (using team.member-join instead of a dedicated team.app-create event), and adjusts integration tests accordingly.
Changes:
- Emit
EdMemberJoinwhen creating an app user (replacing the prior app-create event usage). - Remove
EdAppCreatefrom the team event data model and its JSON parsing/generation. - Expand integration tests to assert websocket + team-notification behavior for app users, and adjust list-users expectations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs | Switches app creation team event from EdAppCreate to EdMemberJoin. |
| libs/wire-api/src/Wire/API/Event/Team.hs | Removes EdAppCreate from EventData and related JSON parsing/generation paths. |
| integration/test/Test/Apps.hs | Adds websocket/team-notification assertions for app create/delete; refines list-users expected shape. |
| changelog.d/3-bug-fixes/WPB-23764-app-events | Documents the change in event expectations and integration coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fisx
marked this pull request as draft
March 23, 2026 12:09
fisx
force-pushed
the
WPB-23764-app-events
branch
from
March 23, 2026 12:27
79f1c6f to
686879c
Compare
fisx
marked this pull request as ready for review
March 23, 2026 12:28
blackheaven
approved these changes
Mar 24, 2026
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d