Skip to content

WPB-22293 Remove Server response header value - #5179

Merged
battermann merged 5 commits into
developfrom
WPB-22293-backend-internal-domain-registration-endpoint-contains-banners
Apr 14, 2026
Merged

WPB-22293 Remove Server response header value#5179
battermann merged 5 commits into
developfrom
WPB-22293-backend-internal-domain-registration-endpoint-contains-banners

Conversation

@battermann

@battermann battermann commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann
battermann marked this pull request as ready for review April 13, 2026 15:57
@battermann
battermann requested review from a team as code owners April 13, 2026 15:57
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 13, 2026
@battermann
battermann requested a review from Copilot April 13, 2026 16:07

@supersven supersven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the HTTP Server response header value across services that use Network.Wai.Utilities.Server.newSettings, and aligns Stern’s domain-registration “get” endpoint behavior with Brig by propagating Brig’s HTTP status codes (notably 404 after deletion).

Changes:

  • Clear Warp’s server name (setServerName "") in the shared WAI/Warp settings helper to avoid exposing a Server header value.
  • Update Stern’s runClientToHandler to propagate status codes from servant-client FailureResponse (e.g., return 404 instead of 400).
  • Switch Spar to the shared newSettings/defaultServer setup and adjust Stern integration test expectations accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/stern/test/integration/API.hs Tightens assertion to expect 404 after domain-registration deletion.
tools/stern/src/Stern/Intra.hs Propagates Brig status codes for servant-client FailureResponse errors.
services/spar/src/Spar/Run.hs Uses shared WAI/Warp server settings (newSettings/defaultServer) instead of direct Warp settings.
libs/wai-utilities/src/Network/Wai/Utilities/Server.hs Sets Warp server name to empty string to remove Server header value.
changelog.d/5-internal/WPB-22293 Changelog entry for Stern/Brig error propagation behavior.
changelog.d/3-bug-fixes/WPB-22293 Changelog entry for removing Server header value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/stern/src/Stern/Intra.hs
Comment thread services/spar/src/Spar/Run.hs
@battermann
battermann merged commit a8272c0 into develop Apr 14, 2026
10 checks passed
@battermann
battermann deleted the WPB-22293-backend-internal-domain-registration-endpoint-contains-banners branch April 14, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants