WPB-22293 Remove Server response header value - #5179
Merged
battermann merged 5 commits intoApr 14, 2026
Merged
Conversation
battermann
marked this pull request as ready for review
April 13, 2026 15:57
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the HTTP Server response header value across services that use Network.Wai.Utilities.Server.newSettings, and aligns Stern’s domain-registration “get” endpoint behavior with Brig by propagating Brig’s HTTP status codes (notably 404 after deletion).
Changes:
- Clear Warp’s server name (
setServerName "") in the shared WAI/Warp settings helper to avoid exposing aServerheader value. - Update Stern’s
runClientToHandlerto propagate status codes fromservant-clientFailureResponse(e.g., return404instead of400). - Switch Spar to the shared
newSettings/defaultServersetup and adjust Stern integration test expectations accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/stern/test/integration/API.hs | Tightens assertion to expect 404 after domain-registration deletion. |
| tools/stern/src/Stern/Intra.hs | Propagates Brig status codes for servant-client FailureResponse errors. |
| services/spar/src/Spar/Run.hs | Uses shared WAI/Warp server settings (newSettings/defaultServer) instead of direct Warp settings. |
| libs/wai-utilities/src/Network/Wai/Utilities/Server.hs | Sets Warp server name to empty string to remove Server header value. |
| changelog.d/5-internal/WPB-22293 | Changelog entry for Stern/Brig error propagation behavior. |
| changelog.d/3-bug-fixes/WPB-22293 | Changelog entry for removing Server header value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
battermann
deleted the
WPB-22293-backend-internal-domain-registration-endpoint-contains-banners
branch
April 14, 2026 09:25
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d