Fix CSP header omitting for versioned SAML endpoints - #5288
Merged
supersven merged 6 commits intoJun 25, 2026
Conversation
The prior URL regex was intended to cover SAML endpoints, but did not cover the version path segment. The expected behaviour is that - in the multi-ingress case - we omit CSP headers for the SAML endpoints. This implicitly resembles the non-multi-ingress case.
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the multi-ingress CSP injection logic so that CSP headers continue to be omitted for SAML SSO endpoints even when those endpoints are accessed through a versioned API prefix (e.g. /v15/sso/...). This aligns multi-ingress behavior with the non-multi-ingress setup and avoids breaking SAML flows.
Changes:
- Extend the nginx
configuration-snippetURI regex to also match versioned SAML endpoints (/v[0-9]+/sso/...) and therefore skip CSP injection for them. - Add clarifying inline comments explaining why SAML endpoints must be excluded from CSP header setting.
- Add a changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/nginx-ingress-services/templates/ingress.yaml | Updates the CSP-skip regex to include optional /vN prefix for SAML endpoints in multi-ingress. |
| changelog.d/3-bug-fixes/multi-ingress-saml-csp | Documents the bug fix for versioned SAML endpoints receiving CSP headers. |
supersven
marked this pull request as ready for review
June 24, 2026 09:09
akshaymankar
approved these changes
Jun 24, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior URL regex was intended to cover SAML endpoints, but did not cover the version path segment.
The expected behaviour is that - in the multi-ingress case - we omit CSP headers for the SAML endpoints. This implicitly resembles the non-multi-ingress case.
Checklist
changelog.d