[chore] background-worker: remove config http calls to galley - #5313
Merged
battermann merged 3 commits intoJul 3, 2026
Conversation
battermann
marked this pull request as ready for review
July 3, 2026 09:37
blackheaven
approved these changes
Jul 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes background-worker’s dependency on internal Galley HTTP/RPC calls for “configured feature flags” and “conversation subsystem config” by constructing these values directly from the loaded Galley config, and deletes the corresponding internal Galley endpoints.
Changes:
- Removed internal Galley routes/handlers for
GET /i/features/configuredandGET /i/conversations/configand removed the corresponding RPC effect operations. - Extended background-worker
Envto carryfeatureFlagsandconversationSubsystemConfig, and wired interpreters to use these local values instead of fetching from Galley. - Updated background-worker unit tests to construct the new
Envfields; added changelog entry.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/galley/src/Galley/API/Internal.hs | Drops internal handlers for conversation config and configured feature flags. |
| services/background-worker/test/Test/Wire/Util.hs | Updates test Env construction with featureFlags and conversationSubsystemConfig. |
| services/background-worker/test/Test/Wire/BackendNotificationPusherSpec.hs | Updates local test Env records to include new fields. |
| services/background-worker/src/Wire/Effects.hs | Switches interpreters to use env.featureFlags / env.conversationSubsystemConfig instead of Galley RPC calls. |
| services/background-worker/src/Wire/BackgroundWorker/Env.hs | Adds featureFlags and conversationSubsystemConfig to Env and builds them from Galley config (including loading MLS keys). |
| libs/wire-subsystems/test/unit/Wire/MockInterpreters/GalleyAPIAccess.hs | Removes mock support for deleted Galley API access operations. |
| libs/wire-subsystems/src/Wire/GalleyAPIAccess/Rpc.hs | Removes RPC calls for deleted internal Galley endpoints. |
| libs/wire-subsystems/src/Wire/GalleyAPIAccess.hs | Removes GalleyAPIAccess constructors for deleted operations. |
| libs/wire-api/src/Wire/API/Routes/Internal/Galley.hs | Removes internal API route definitions for the deleted endpoints. |
| changelog.d/5-internal/bg-worker-config-clean-up | Documents the background-worker config fetch removal. |
battermann
force-pushed
the
battermann/chore-remove-config-http-call-to-galley
branch
from
July 3, 2026 10:07
d43705d to
8b47bb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d