Skip to content

[chore] background-worker: remove config http calls to galley - #5313

Merged
battermann merged 3 commits into
developfrom
battermann/chore-remove-config-http-call-to-galley
Jul 3, 2026
Merged

[chore] background-worker: remove config http calls to galley#5313
battermann merged 3 commits into
developfrom
battermann/chore-remove-config-http-call-to-galley

Conversation

@battermann

@battermann battermann commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann
battermann marked this pull request as ready for review July 3, 2026 09:37
@battermann
battermann requested review from a team as code owners July 3, 2026 09:37
@battermann
battermann requested a review from Copilot July 3, 2026 09:37
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes background-worker’s dependency on internal Galley HTTP/RPC calls for “configured feature flags” and “conversation subsystem config” by constructing these values directly from the loaded Galley config, and deletes the corresponding internal Galley endpoints.

Changes:

  • Removed internal Galley routes/handlers for GET /i/features/configured and GET /i/conversations/config and removed the corresponding RPC effect operations.
  • Extended background-worker Env to carry featureFlags and conversationSubsystemConfig, and wired interpreters to use these local values instead of fetching from Galley.
  • Updated background-worker unit tests to construct the new Env fields; added changelog entry.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
services/galley/src/Galley/API/Internal.hs Drops internal handlers for conversation config and configured feature flags.
services/background-worker/test/Test/Wire/Util.hs Updates test Env construction with featureFlags and conversationSubsystemConfig.
services/background-worker/test/Test/Wire/BackendNotificationPusherSpec.hs Updates local test Env records to include new fields.
services/background-worker/src/Wire/Effects.hs Switches interpreters to use env.featureFlags / env.conversationSubsystemConfig instead of Galley RPC calls.
services/background-worker/src/Wire/BackgroundWorker/Env.hs Adds featureFlags and conversationSubsystemConfig to Env and builds them from Galley config (including loading MLS keys).
libs/wire-subsystems/test/unit/Wire/MockInterpreters/GalleyAPIAccess.hs Removes mock support for deleted Galley API access operations.
libs/wire-subsystems/src/Wire/GalleyAPIAccess/Rpc.hs Removes RPC calls for deleted internal Galley endpoints.
libs/wire-subsystems/src/Wire/GalleyAPIAccess.hs Removes GalleyAPIAccess constructors for deleted operations.
libs/wire-api/src/Wire/API/Routes/Internal/Galley.hs Removes internal API route definitions for the deleted endpoints.
changelog.d/5-internal/bg-worker-config-clean-up Documents the background-worker config fetch removal.

Comment thread libs/wire-api/src/Wire/API/Routes/Internal/Galley.hs
@battermann
battermann force-pushed the battermann/chore-remove-config-http-call-to-galley branch from d43705d to 8b47bb5 Compare July 3, 2026 10:07
@battermann
battermann merged commit 0210fcf into develop Jul 3, 2026
10 checks passed
@battermann
battermann deleted the battermann/chore-remove-config-http-call-to-galley branch July 3, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants